1282168 - Orange loading throbber isn't shown anymore when loading pages

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Marco Castelluccio [:marco]]

[Tracking Requested - why for this release]: Regression from bug 1280131.

Comment 1

[Marcia Knous [:marcia]]

Tracking 50+ for this visible Linux regression.

Comment 2

[:Gijs (he/him)]

I couldn't reproduce this earlier today. Are you using a hidpi system/screen?

Comment 3

[Marco Castelluccio [:marco]]

(In reply to :Gijs Kruitbosch from comment #2)
> I couldn't reproduce this earlier today. Are you using a hidpi system/screen?

Yes. 2880x1620 with scaling set to 1.75.

Comment 4

[:Gijs (he/him)]

This only happens because the 1.1dppx selector for [busy] is later in the combined browser.css stylesheet than the one for [progress], which is what normally produces the orange throbber, so we always show the grey throbber rather than the orange one. We should fix that, but for nightly I don't think this is life-threatening right now.

Rather than increasing the specificity of the lodpi rule, adding a duplicate hidpi rule only to Linux to fix this there, or adding !important to that particular rule (which probably has other side-effects I wouldn't like), I think the best way to fix this is to just fix bug 1280510 instead. I'll nominate that for tracking and do an additional prod of UX for assets later today.

Comment 5

[:Gijs (he/him)]

Marking wfm because bug 1280510 is now fixed.

Comment 6

[Marco Castelluccio [:marco]]

The throbber is blue now instead of orange. Is it expected?

Comment 7

[:Gijs (he/him)]

(In reply to Marco Castelluccio [:marco] from comment #6)
> The throbber is blue now instead of orange. Is it expected?

Yes, see bug 1280510.