Closed
Bug 1280174
Opened 10 years ago
Closed 1 year ago
Get rid of MainThreadWorkerRunnable
Categories
(Core :: DOM: Workers, enhancement, P3)
Tracking
()
RESOLVED
DUPLICATE
of bug 1769913
People
(Reporter: baku, Unassigned)
References
Details
(Whiteboard: btpp-active, dom-lws-bugdash-triage)
Attachments
(1 file)
|
5.06 KB,
patch
|
Details | Diff | Splinter Review |
Still cleaning WorkerRunnables: In this patch I remove MainThreadWorkerRunnable.
We can do it because in a previous patch I changed the assertions and because we should use ModifyBusyCount in BindingUtils::ReleaseRunnable, in WorkerFetchResponseRunnable, in WorkerFetchResponseEndRunnable and in ContinueConsumeBodyRunnable.
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8762804 -
Flags: review?(jonas)
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8762804 -
Flags: review?(jonas)
|
||
Updated•10 years ago
|
Whiteboard: btpp-active
|
|
||
Updated•8 years ago
|
Priority: -- → P3
|
||
Updated•7 years ago
|
Assignee: amarchesini → nobody
|
||
Updated•3 years ago
|
Severity: normal → S3
|
||
Comment 2•1 year ago
|
||
Should this be duped or otherwise altered? We still have this class (and it has more subclasses now than it had before), but we've also adopted a policy of having the runnable classes identify the thread involvements of the workers, so I think we might actually want this clarity now.
Type: defect → enhancement
Flags: needinfo?(echuang)
Whiteboard: btpp-active → btpp-active, dom-lws-bugdash-triage
|
||
Comment 3•1 year ago
|
||
I think this bug probably is not valid anymore, or should be dupe of bug 1769913.
Yes, just like you commented, MainThreadWorkerRunnable is still used and may even be used more. We did want this clarity, which is good for debugging to identify where the Runnable dispatched from.
Status: NEW → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1769913
Flags: needinfo?(echuang)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•