Closed Bug 1280067 Opened 7 years ago Closed 7 years ago

WorkerRunnable should use WorkerThreadModifyBusyCount as default param

Categories

(Core :: DOM: Workers, defect)

Product:
Core
Component:
DOM: Workers
Version:
49 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Blocks 1 open bug)

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

runnable2.patch
14.25 KB, patch
sicking
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch runnable2.patch — — Splinter Review 

        Attachment #8762698 -
        Flags: review?(jonas)

    
    

    
  
Comment on attachment 8762698 [details] [diff] [review]
runnable2.patch

Review of attachment 8762698 [details] [diff] [review]:
-----------------------------------------------------------------

I would personally probably not put in a default value here. But you work more with this code than I do so I'm fine with this if it's what you prefer.

        Attachment #8762698 -
        Flags: review?(jonas) → review+

    
  
Depends on: 1279977

    
  
Blocks: 1280164

    
  
Blocks: 1280174

    
  
Blocks: 1280167

    
  
Blocks: 1280168
Whiteboard: btpp-active

    
    

    
  
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b73fb8d947d6
WorkerThreadModifyBusyCount should be the default value for WorkerRunnable, r=sicking

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b73fb8d947d6
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox50:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50

          You need to log in
          before you can comment on or make changes to this bug.