128035 - homeURL and workURL values are wrong (swapped) for LDAP, ldif import and export.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Robert John Churchill]

The homeURL and workURL values are incorrectly swapped in the Address Book (both
in the main display when a single card is chosen, as well as in the Card display
when showing all attributes for an entry).

Comment 1

[Robert John Churchill]

Attachment: Patch

Here is a patch for 'ya... simple XUL/JS changes.

Comment 2

[Robert John Churchill]

Sigh... only one problem with that patch; it transposes any existing cards
(which is wrong.)

Comment 3

[Robert John Churchill]

Attachment: Better patch

Better patch that changes the LDAP property mapping (so only LDAP-fetched cards
are tweaked) so that existing Personal Addressbook cards remain correct.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

This looks fine to me, but I'd like Seth or John to verify that this is the
right thing.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Additionally, we may need to change the other two redundant tables where this
info is kept.

Comment 6

[John Marmion]

Attachment: Patch to fix homeurl versus workurl

Dan, yes Robert's patch looks good. I have updated the patch to include the
other two cases I presume you are talking about. The other area where is this
is used is in Outlook but it is correct there.

Comment 7

[(not reading, please use [e-mail] instead)]

taking a look...

rjc's initial patch makes sense, but I need to see if john's additions to the
patch are also correct.

I want to double check and make sure all these changes are correct.

Comment 8

[Ninoschka Baca]

1. Import Outlook AB: I can see the problem
2. Import Outlook Express AB: ok.

So is this fix specific for importing from an Outlook Address Book?

Comment 9

[John Marmion]

This bug is related to LDAP only. My comment about Outlook related to the
dynamic integration of Outlook and Outlook Express in Mozilla (bug #78931 and
bug #83103) as opposed to the Importing of Outlook and Outlook Express. 

Yes, I also believe we have a problem in Importing from Outlook. It appears that
we map the PR_BUSINESS_HOME_PAGE (confusing  name!) to Mozilla's Home Web Page
rather than the Business Web Page. But because Outlook uses only one web page
field, then this may explain why this is not such a big issue. In contrast
Outlook Express supports both a Home Web Page and a Business Web Page. It
appears following bug #93588 that this is now fixed.

So to be accurate we could create a new bug for the Import of Outlook.

Comment 10

[(not reading, please use [e-mail] instead)]

dmose wrote:

"Additionally, we may need to change the other two redundant tables where this
info is kept."

dan's guess is right, export and import have issues.  it looks like john's last 
patch addresses some of these, but not all.

I'll attach another patch.

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

Comment 12

[John Marmion]

This latest patch looks good. r=john.marmion

Comment 13

[David :Bienvenu]

Comment on attachment 73177 [details] [diff] [review]
updated patch

sr=bienvenu

Comment 14

[racham]

Comment on attachment 73177 [details] [diff] [review]
updated patch

r=bhuvan

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 73177 [details] [diff] [review]
updated patch

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 16

[(not reading, please use [e-mail] instead)]

fixed

thanks to rjc for the bug and the initial patch, and to john for the follow up 
patches and the review.

Comment 17

[Ninoschka Baca]

Setting qa contact to Yulian.

Comment 18

[Ninoschka Baca]

fyi: logged bug# 134014 to track the import from outlook problem where the web
pages are not mapped correctly (as stated in comment# 9).

Comment 19

[yulian chang]

Robert,
Would you confirm the fix with your Directory Server (at home?) which uses the
attributes: "homeURL" and "workURL" ? Thanks!

Comment 20

[Robert John Churchill]

Confirmed.

Comment 21

[yulian chang]

Verified by reporter