1280404 - Implement chrome.webNavigation.onTabReplaced

Status: VERIFIED FIXED

(WebExtensions :: Compatibility, defect, P2)

Description

[Matthew Wein [:mattw]]

AddBlock, which is a top addon in the Chrome Webstore, uses this method. Currently, when running this addon as a WebExtension, it throws the following error: `TypeError: chrome.webNavigation.onTabReplaced is undefined`.

Comment 1

[Kris Maglione [:kmag]]

This just needs a stub listener.

Comment 2

[Bob Silverberg [:bsilverberg]]

AdBlock uses this listener to remove data for the replaced tab. Do we not have the concept of a replaced tab in Firefox, and is that why you are suggesting implementing this with just a stub?

Comment 3

[Kris Maglione [:kmag]]

No, we don't have anything equivalent to this.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

:bsilverberg it seems that this bugzilla issue is about adding the webNavigation version of what we are already doing for tabs.onReplaced:

     ...
     onReplaced: ignoreEvent(context, "tabs.onReplaced"),
     ...

From: https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/ext-tabs.js#335

`ignoreEvent` is a small helper that we can import from ExtensionUtils.jsm (https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/ExtensionUtils.jsm#738), it creates an error message which warns that the specified API event has not been implemented, but it doesn't block the caller from going on with the rest of its execution.

(the error is reported in the Browser Console, it is associated with the called window context and to the fileName / lineNumber of the caller, which is helpful to point out to the developer where the addon is trying to use the ignored/unsupported API event)

Comment 5

[Bob Silverberg [:bsilverberg]]

Thanks Luca, that's perfect!

Comment 6

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1280404 - Implement chrome.webNavigation.onTabReplaced,

Review commit: https://reviewboard.mozilla.org/r/78788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78788/

Comment 7

[Andrew Swan [:aswan]]

Comment on attachment 8791362 [details]
Bug 1280404 - Implement chrome.webNavigation.onTabReplaced,

https://reviewboard.mozilla.org/r/78788/#review77410

Comment 8

[Bob Silverberg [:bsilverberg]]

Try looks good, requesting check in.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd305c9791cb
Implement chrome.webNavigation.onTabReplaced, r=aswan

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd305c9791cb

Comment 11

[CosminB]

I could see this error message on Firefox 51.0a1 (20160918030408)

This issue is verified as fixed on Firefox 52.0a1 (2016-09-21), the error message: `TypeError: chrome.webNavigation.onTabReplaced is undefined` is no longer thrown in the browser console.