1281799 - Don't allow setting internal URLs as the home page

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P3)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Open a page in reader view
2. Set it as a homepage
3. Set New Tab to "Open your homepage"
4. Open a new tab

Actual results:
- A blank tab is opened.

Expected results:
- The homepage should be displayed. 
or
- Pages in reader view cannot be added as a homepage.

Note:
- tapping the homepage button does nothing
- Homepage in settings: "http://localhost:6571/reader-mode/...."
- reproducible on 5.0b(12)

Comment 1

[Brian Nicholson (:bnicholson)]

Maurya, this is similar to the bookmarks bug you're working on in that we want to disable a feature depending on whether the URL is internal or not. If you're looking for something else after finishing the other bug, this could be a good option!

Comment 2

[Maurya Talisetti]

Sure Brian, thanks! I'll add it to my queue.

Comment 3

[Maurya Talisetti]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2157

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8800576 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2157

Looks good, but I think we should avoid adding accessibility IDs when possible.

Comment 5

[Maurya Talisetti]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2157

Comment 6

[Maurya Talisetti]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2157

Comment 7

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla-mobile/firefox-ios/commit/378320e00ee4405793561ffcffa657e9f8e54898