Closed Bug 1281799 Opened 9 years ago Closed 9 years ago

Don't allow setting internal URLs as the home page

Categories

(Firefox for iOS :: General, defect, P3)

Product:
Firefox for iOS
Component:
General
Platform:
All
iOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---
fxios-v5.0 --- affected
fxios-v6.0 --- affected

People

(Reporter: TeoVermesan, Assigned: maurya1985, Mentored)

References

Details

(Whiteboard: [MobileAS])

Attachments

(1 file, 2 obsolete files)

Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2157
55 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
Steps to reproduce: 1. Open a page in reader view 2. Set it as a homepage 3. Set New Tab to "Open your homepage" 4. Open a new tab Actual results: - A blank tab is opened. Expected results: - The homepage should be displayed. or - Pages in reader view cannot be added as a homepage. Note: - tapping the homepage button does nothing - Homepage in settings: "http://localhost:6571/reader-mode/...." - reproducible on 5.0b(12)
Maurya, this is similar to the bookmarks bug you're working on in that we want to disable a feature depending on whether the URL is internal or not. If you're looking for something else after finishing the other bug, this could be a good option!
Mentor: bnicholson
Flags: needinfo?(maurya1985)
Summary: Page in reader view set as a homepage is not displayed → Don't allow setting internal URLs as the home page
Sure Brian, thanks! I'll add it to my queue.
Flags: needinfo?(maurya1985)
Assignee: nobody → maurya1985
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [MobileAS]
Rank: 10
Depends on: 1304053
Priority: P3 → P1
Comment on attachment 8800576 [details] [review] Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2157 Looks good, but I think we should avoid adding accessibility IDs when possible.
Attachment #8800576 - Flags: review?(bnicholson) → feedback+
tracking-fxios: 6.0+ → +
Priority: P1 → P3
Attachment #8800576 - Attachment is obsolete: true
Attachment #8805761 - Attachment is obsolete: true
Attachment #8805761 - Flags: review?(bnicholson)
Attachment #8805822 - Flags: review?(bnicholson)
Attachment #8805822 - Flags: review?(bnicholson) → review+
https://github.com/mozilla-mobile/firefox-ios/commit/378320e00ee4405793561ffcffa657e9f8e54898
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
See Also: → 1346582
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: