1282050 - "clear downloads" is grayed out when there is an active download till one download is removed from histroy

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Hussam Al-Tayeb]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160623005403

Steps to reproduce:

First of all, follow the instructions carefully otherwise the bug will not show up.

1) Make sure no active downloads are in process. Close all firefox instances (if you don't do this, you won't see the bug).
2) Open firefox and start a large download that takes 30 minutes.
3) Open Library -> downloads and right click on any download in your history. Noticed the "clear downloads" option is greyed out.
4) Right click on another download and "remove from history".
5) Right click on any other download and notice that "clear downloads" is active again.
6) Finish the above steps BEFORE the currently active file is completely downloaded.

If you don't see the bug, stop the active download, remove it from history, close firefox, start it again and repeat the above steps.

Comment 1

[Hussam Al-Tayeb]

Attachment: before.png

Comment 2

[Hussam Al-Tayeb]

Attachment: after.png

Comment 3

[Théo Chevalier]

This should be fixed next week by bug 1280799. Please reopen if it doesn’t fix this one

Comment 4

[Hussam Al-Tayeb]

It looks like bug 1280799 is fixed.
I just did a trunk build and I still see my issue.

Comment 5

[Théo Chevalier]

Hey Hussam, thanks for checking. Could you check with latest Nightly as well? I can’t reproduce anymore.

Comment 6

[Hussam Al-Tayeb]

Attachment: Bug with june 26 official nightly

Hi. I think we are talking about different issues. bug 1280799 fixed what happens when the download is cancelled.
In this bug, while a download is in progress, the 'clear downloads' button is greyed out. Then if I remove one previous download from history, "clear downloads" is no longer greyed out (while a download is still in progress).

Comment 7

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0

I have managed to reproduce this issue on the latest Nightly (50.0a1, Build ID 20160627030215). I have also ran mozregression and reached the following:

Last good revision: 0a58b5b8a407f1420ce27b09554305c6b4bebfa2
First bad revision: 3b3428c04743ca6da4472583dc809ae78cd3a5db
Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=0a58b5b8a407f1420ce27b09554305c6b4bebfa2&tochange=3b3428c04743ca6da4472583dc809ae78cd3a5db

Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1117145

Comment 9

[:Paolo Amadini]

Attachment: Bug 1282050 - Fix the updating of download commands in the Library.

Review commit: https://reviewboard.mozilla.org/r/64594/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64594/

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8771426 [details]
Bug 1282050 - Fix the updating of download commands in the Library.

https://reviewboard.mozilla.org/r/64594/#review61734

Comment 12

[George R. Goffe]

Hi,

I reported similar behavior some time ago and am happy to see someone working on the bug. I also have suggested adding column sorting for the various columns (i.e., name, speed, size, download progress) if it's an easy thing to do. Maybe there's a widget with this capability that could be used instead of the one that is being used? Just a thought.

I'm also seeing a situation where disk full halts the downloads but when the fullness is resolved, the downloads do NOT continue. Also, I'm seeing a situation with download in progress being continued after a browser crash but this download manager widget gives no indication that anything is running. Subsequent termination of the browser happens as if there were no downloads in progress.

I know, make a new bug report.

Sorry for the shameless posting.

George...

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/1249782e3771
Fix the updating of download commands in the Library. r=jaws

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1249782e3771

Comment 15

[:Paolo Amadini]

[Tracking Requested - why for this release]:
Fixes a UI regression in the Library window. Safe to uplift to Aurora.

Comment 16

[Marcia Knous [:marcia]]

Tracking 49+ for this visible UI regression in the Library Window.

Comment 17

[:Paolo Amadini]

Comment on attachment 8771426 [details]
Bug 1282050 - Fix the updating of download commands in the Library.

Approval Request Comment
[Feature/regressing bug #]: Bug 1117145
[User impact if declined]: Inconsistent enabled/disabled state of commands in the Library window.
[Describe test coverage new/current, TreeHerder]: Landed on mozilla-central
[Risks and why]: There are no automated regression tests. The bug was essentially caused by a typo introduced during the refactoring in bug 1117145. This patch fixes the typo and restores the original logic. Therefore the risk of further regressions is probably lower than the average for code without test coverage.
[String/UUID change made/needed]: None

Comment 18

[Gerry Chang [:gchang]]

Comment on attachment 8771426 [details]
Bug 1282050 - Fix the updating of download commands in the Library.

This fixes a UI regression in the Library Window. Take it in aurora.

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/68533b8aca1f

Comment 20

[Tanvir Rahman]

I have reproduced this bug with Nightly 50.0a1(2016-06-24) on Windows 10, 64 bit.

The Bug's fix is now verified on- 

Latest Beta 49.0b6
Build ID 	20160822111414
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0

Latest Aurora 50.0a2
Build ID 	20160824004001
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0

[bugday-20160824]

Comment 21

[Andrei Vaida [:avaida]]

This is verified fixed on:

   - 49.0b8-build1 (20160829102229)
   - 50.0a2 (2016-08-31)

using Windows 10 x64, Mac OS X 10.10.5 and Ubuntu 14.04 x86 - the "Clear
Downloads" option is now working as expected.

Based on Tanvir's results (Comment 20) and my own findings, we can safely mark
this as verified.

Comment 22

[Liu Xing]

48.0.1 also affected.

Comment 23

[Jared Wein [:jaws] (please needinfo? me)]

Paolo, are you aware of 48.0.1 being affected? Not much we can do about 48, we should probably mark this as wontfix for 48.

Comment 24

[:Paolo Amadini]

Yes, this affects 48 and the fix will be released soon in 49. The partial fix in bug 1280799 is already in 48 though. Thanks!