1283211 - Port bug 1281793 to c-c - Remove some non-used telemetry IDs

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Richard Marti (:Paenglab)]

Building TB gets this error (and more):
z:/Mozilla/comm-central/mail/app/nsMailApp.cpp(353): error C2039: 'EARLY_GLUESTARTUP_READ_OPS': is not a member of 'mozilla::Telemetry'

This is a fallout of bug 1281793

Comment 1

[Richard Marti (:Paenglab)]

Attachment: telemetryFix.patch

This fixes it locally. I add in addition to jcranmer also aleth to review the patch. The first who has time can review it.

Comment 2

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/48b885e619ce

Comment 3

[aleth [:aleth]]

Comment on attachment 8766444 [details] [diff] [review]
telemetryFix.patch

Review of attachment 8766444 [details] [diff] [review]:
-----------------------------------------------------------------

This file is pretty much in sync with nsBrowserApp.cpp, so while I don't pretend to understand this code, rs+ as it's a straight port of https://hg.mozilla.org/mozilla-central/rev/b022cc28da9b.

Comment 4

[aleth [:aleth]]

Heh, midaired :-)

Comment 5

[aleth [:aleth]]

We'll probably need the same changes to im/app/nsMain.cpp and nsSuiteApp.cpp.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: IBtelemetryFix.patch

Not tested but should work as it's the same change as for TB.

Comment 7

[aleth [:aleth]]

Comment on attachment 8766456 [details] [diff] [review]
IBtelemetryFix.patch

Review of attachment 8766456 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 8

[Richard Marti (:Paenglab)]

Attachment: SuiteTelemetryFix.patch

Patch for Suite

Comment 9

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/608fcae32d69

Comment 12

[Stefan [:stefanh]]

Comment on attachment 8766461 [details] [diff] [review]
SuiteTelemetryFix.patch

Since this is a straight port, I'm stealing this from Philip.

Comment 13

[Stefan [:stefanh]]

https://hg.mozilla.org/comm-central/rev/fb147b02529e