1283830 - move confvars.sh to moz.configure

Status: NEW

(Firefox Build System :: General, task)

Description

[(not currently active) Ted Mielczarek]

I haven't seen a bug on this and I don't remember anyone discussing it, but I think we should move confvars.sh to moz.configure. There aren't that many of them in the tree:
https://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=path:confvars.sh

and most of the content is just straight `VAR=value`, with a few conditionals sprinkled about:
https://dxr.mozilla.org/mozilla-central/rev/b69a5bbb5e40bd426e35222baa600b481e50d265/browser/confvars.sh#16

We should probably just convert these to sandbox-evaluated Python. I don't know what would be most straightforward--just treating them as if they were moz.configure files, or implementing a more-restrictive sandbox ala moz.build.

This blocks moving things from old-configure.in that rely on variables set in confvars.sh, like MOZ_RUST_MP4PARSE:
https://dxr.mozilla.org/mozilla-central/rev/b69a5bbb5e40bd426e35222baa600b481e50d265/old-configure.in#2878

Comment 1

[Chris Manchester (limited bugmail, email directly)]

I moved several confvars.sh things over and implemented a template to make this pretty simple in bug 1257326.

https://groups.google.com/forum/#!topic/mozilla.dev.builds/_JLLvSrHmSQ has a brief example of the approach (option 1 from the first message there was implemented).

For anything that doesn't depend on things that are still in old-configure, this should be an open and shut case.

Comment 2

[(not currently active) Ted Mielczarek]

I...totally missed that work. Hooray!