1895251 - Move confvars.sh to confvars.py

Status: NEW

(Firefox Build System :: General, task)

Description

[[:sergesanspaille]]

confvars.sh is used to customize per-application builds, but it's scope is not clearly documented. Moving to a sandboxed python function would document the behavior, in addition to helping moving forward to the moz.configure migration.

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1895251 - Move confvars.sh to confvars.py r=glandium

This bounds the scope of what can be done through confvars.

One noticeable change is the removal of setting MOZ_UPDATER environment variable
in tools/update-programs/confvars, but that environment variable wasn't
honored anyway.

Comment 2

[Mathew Hodson]

This is similar to bug 1283830

Comment 3

[[:sergesanspaille]]

Attachment: Bug 1895251 - Move branding code from old-configure to moz.configure r=glandium

Comment 4

[k4sum1]

This does not seem like a good change. As of 138, I'm no longer able to set MOZ_APP_UA_NAME, MOZ_APP_VENDOR, or MOZ_APP_PROFILE in branding configure.sh. I don't want to stuff this all in moz.configure as it would mean anyone doing a basic rebuild of my browser would have it show up as being from my vendor, having the UA name, and using the same profile directory which I don't want to happen.

So I think workaround set it in mozconfig, however I can't do that either. I just get a similar error "can not be set by mozconfig. Values are accepted from: implied"

Is there any way to set these without using a moz.configure file? Or do I have to just revert these changes for my fork?