1234518 - Investigate MOZ_SERVICES_HEALTHREPORT, MOZ_SERVICES_METRICS and their uses

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

Since we're removing FHR, we need to investigate how its defines are used. The code covered by MOZ_SERVICES_HEALTHREPORT, MOZ_SERVICES_METRICS and any AppConstants.jsm equivalents should be either removed, or changed to use MOZ_TELEMETRY_REPORTING.

See:
- https://dxr.mozilla.org/mozilla-central/search?q=MOZ_SERVICES_HEALTHREPORT&redirect=false&case=true
- https://dxr.mozilla.org/mozilla-central/search?q=MOZ_SERVICES_METRICS&redirect=false&case=true

Comment 1

[Alessio Placitelli [:Dexter]]

It looks like Thunderbid is using UT, but is not using about:healthreport. This sounds like a legit use-case, so maybe the best thing here is to keep using MOZ_SERVICES_HEALTHREPORT to enable/disable about:healthreport/Selfsupport, strictly using MOZ_TELEMETRY_REPORTING just for, well, Telemetry.

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: bug1234518.patch

The sections in [0] will be removed in bug 1237983.

[0] - https://dxr.mozilla.org/mozilla-central/search?q=MOZ_SERVICES_HEALTHREPORT+path%3Aservices&redirect=false&case=true

Comment 3

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8710488 [details] [diff] [review]
bug1234518.patch

Review of attachment 8710488 [details] [diff] [review]:
-----------------------------------------------------------------

Please file follow-ups:
* rename MOZ_SERVICES_HEALTHREPORT to something more fitting - MOZ_ENABLE_HEALTHREPORT or so?
* xulrunner/confvars.sh - should we remove MOZ_SERVICES_HEALTHREPORT?

Comment 4

[Alessio Placitelli [:Dexter]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a849104fedc8

Comment 5

[Alessio Placitelli [:Dexter]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #3)
> Comment on attachment 8710488 [details] [diff] [review]
> bug1234518.patch
> 
> Review of attachment 8710488 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please file follow-ups:
> * rename MOZ_SERVICES_HEALTHREPORT to something more fitting -
> MOZ_ENABLE_HEALTHREPORT or so?

Filed bug 1242591.

> * xulrunner/confvars.sh - should we remove MOZ_SERVICES_HEALTHREPORT?

Filed bug 1242607.

Comment 6

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/fx-team/rev/1ce8c9bac2a7e34f4dccbe2c047809e52333a8b2
Bug 1234518 - Clean MOZ_SERVICES_HEALTHREPORT and and MOZ_SERVICES_METRICS. r=gfritzsche

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1ce8c9bac2a7