Closed Bug 1234518 Opened 4 years ago Closed 4 years ago

Investigate MOZ_SERVICES_HEALTHREPORT, MOZ_SERVICES_METRICS and their uses

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect, P1)

defect

Tracking

(firefox46 affected, firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox46 --- affected
firefox47 --- fixed

People

(Reporter: Dexter, Assigned: Dexter)

References

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

Since we're removing FHR, we need to investigate how its defines are used. The code covered by MOZ_SERVICES_HEALTHREPORT, MOZ_SERVICES_METRICS and any AppConstants.jsm equivalents should be either removed, or changed to use MOZ_TELEMETRY_REPORTING.

See:
- https://dxr.mozilla.org/mozilla-central/search?q=MOZ_SERVICES_HEALTHREPORT&redirect=false&case=true
- https://dxr.mozilla.org/mozilla-central/search?q=MOZ_SERVICES_METRICS&redirect=false&case=true
Blocks: 1209088
Points: --- → 2
Priority: -- → P2
Whiteboard: [measurement:client]
Priority: P2 → P1
Assignee: nobody → alessio.placitelli
It looks like Thunderbid is using UT, but is not using about:healthreport. This sounds like a legit use-case, so maybe the best thing here is to keep using MOZ_SERVICES_HEALTHREPORT to enable/disable about:healthreport/Selfsupport, strictly using MOZ_TELEMETRY_REPORTING just for, well, Telemetry.
Comment on attachment 8710488 [details] [diff] [review]
bug1234518.patch

Review of attachment 8710488 [details] [diff] [review]:
-----------------------------------------------------------------

Please file follow-ups:
* rename MOZ_SERVICES_HEALTHREPORT to something more fitting - MOZ_ENABLE_HEALTHREPORT or so?
* xulrunner/confvars.sh - should we remove MOZ_SERVICES_HEALTHREPORT?
Attachment #8710488 - Flags: review?(gfritzsche) → review+
(In reply to Georg Fritzsche [:gfritzsche] from comment #3)
> Comment on attachment 8710488 [details] [diff] [review]
> bug1234518.patch
> 
> Review of attachment 8710488 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please file follow-ups:
> * rename MOZ_SERVICES_HEALTHREPORT to something more fitting -
> MOZ_ENABLE_HEALTHREPORT or so?

Filed bug 1242591.

> * xulrunner/confvars.sh - should we remove MOZ_SERVICES_HEALTHREPORT?

Filed bug 1242607.
https://hg.mozilla.org/integration/fx-team/rev/1ce8c9bac2a7e34f4dccbe2c047809e52333a8b2
Bug 1234518 - Clean MOZ_SERVICES_HEALTHREPORT and and MOZ_SERVICES_METRICS. r=gfritzsche
https://hg.mozilla.org/mozilla-central/rev/1ce8c9bac2a7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
See Also: → 1284010
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.