Bug 1284800 (libyuv-updates)

[meta] Update libyuv to newer upstream version

RESOLVED FIXED

Status

()

P3
normal
RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: sotaro, Assigned: jesup)

Tracking

({meta})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Meta-bug for tracking any issues related to updating libyuv.
(Reporter)

Updated

3 years ago
Depends on: 880419
(Reporter)

Updated

3 years ago
Keywords: meta
(Reporter)

Updated

3 years ago
Alias: libyuv-updates
Summary: (libyuv-updates) (meta) Update libyuv to newer upstream version → [meta] Update libyuv to newer upstream version
(Reporter)

Updated

3 years ago
Depends on: 1284803
Whiteboard: [gfx-noted]
Depends on: 1341543
Keywords: leave-open
MozReview-Commit-ID: 3MK84gHSrLg
Attachment #8839979 - Flags: review?(sotaro.ikeda.g)
Attachment #8839979 - Flags: review?(giles)
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
MozReview-Commit-ID: CDMDXqpGueS
Attachment #8839980 - Flags: review?(mh+mozilla)
Comment on attachment 8839979 [details] [diff] [review]
Create new update script for libyuv

Review of attachment 8839979 [details] [diff] [review]:
-----------------------------------------------------------------

Update script looks good. r=me with the README_MOZILLA issue fixed. The patches look plausible, but I think sotaro should review them for correctness and sufficiency.

::: media/libyuv/README_MOZILLA
@@ +1,1 @@
> +

It's nice to have a file like this with the imported version and upstream url, but this copy seems to be empty? I think you need to seed the file with the expected text for the substitution function in update.py to work. Something like:

YUV-format image scaling and conversion library

The source in this directory was copied from upstream
by running the update.py script. Any changes made relative
to upstream should be reflected in that script, e.g. by
applying patch files after the copy step.

The upstream repository is https://chromium.googlesource.com/libyuv/libyuv

The git commit ID used was r6102.
Attachment #8839979 - Flags: review?(giles) → review+
(Reporter)

Updated

2 years ago
Attachment #8839979 - Flags: review?(sotaro.ikeda.g) → review+
Attachment #8839980 - Flags: review?(mh+mozilla) → review+

Comment 4

2 years ago
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/946da1e13208
Create new update script for libyuv r=sotaro,rillian
https://hg.mozilla.org/integration/mozilla-inbound/rev/c560b9eed8b1
Fix build fallout from moving libyuv into a subdirectory r=ted
Depends on: 1344316
For the future libyuv upstream updates, let's aim to land the changes during the first half of the nightly cycle, unless we have a really good reason to do it closer to the train change.
Depends on: 1346291
(Reporter)

Updated

a year ago
Depends on: 1414440
The leave-open keyword is there and there is no activity for 6 months.
:jesup, maybe it's time to close this bug?
Flags: needinfo?(rjesup)
(Assignee)

Updated

4 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Flags: needinfo?(rjesup)
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.