1285517 - Improve the logging around streamCreated and exception events

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

In attempting to look at connection times, and details of exceptions, there's some issues in the current logging that make this difficult:

- The event parameter "Session.streamCreated" can currently mean either a) we're starting to receive a remote A/V stream or b) we're starting to receive a remote screen share stream.

Whilst A/V will generally be logged before the screen share, we can't always guarantee it, so this makes analysis harder.

Note: we already have separate "Session.subscribeCompleted" and "Session.screen.subscribeCompleted" events.

- Exceptions are not being logged with an indication of if they apply to A/V or screen sharing. I tried to do this in bug 1281252 but I was checking against just the variable for the publisher, rather than the one for the subscriber as well.

Comment 1

[GitHub Autolander Bot]

Attachment: [loop] Standard8:bug-1285517-stats > mozilla:master

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8769254 [details] [review]
[loop] Standard8:bug-1285517-stats > mozilla:master

This is further improvements for logging for the connectivity issues work.

Comment 3

[Ed Lee :Mardak]

Comment on attachment 8769254 [details] [review]
[loop] Standard8:bug-1285517-stats > mozilla:master

r=Mardak with a comment to clarify/think about.

Comment 4

[Mark Banner (:standard8)]

As I mentioned on the PR, I've additionally changed `Session.streamCreated` to `Session.av.streamCreated` for better clarity as to when the new stats kick in.

Comment 5

[Mark Banner (:standard8)]

https://github.com/mozilla/loop/commit/28e16320dabb3adabfafbec39722f5d6f986c604