1285735 - TEST-UNEXPECTED-FAIL | dom/push/test/xpcshell/test_clear_forgetAboutSite.js and TEST-UNEXPECTED-FAIL | toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

First seen on M-C 2016-07-09:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedJob=41610

TEST-UNEXPECTED-FAIL | dom/push/test/xpcshell/test_clear_forgetAboutSite.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js | xpcshell return code: 0 

I assume they have a common cause. Should I be wrong, we can raise another bug later.

The failure in test_removeDataFromDomain.js suggests bug 1071358 but I doubt that since this new failure is perma-orange. Again, I could be wrong ;-)

Comment 1

[aleth [:aleth]]

CONSOLE_MESSAGE: (error) [JavaScript Error: "Failed to load module resource:///modules/ContextualIdentityService.jsm."]

This file is in browser/. Looks like something in toolkit now depends on it, which is wrong.

https://dxr.mozilla.org/comm-central/source/mozilla/toolkit/forgetaboutsite/ForgetAboutSite.jsm#15

Added here https://hg.mozilla.org/mozilla-central/rev/663a083774f4 (Bug 1238183)

Comment 2

[Jorg K (CEST = GMT+2)]

(In reply to aleth [:aleth] from comment #1)
> This file is in browser/. Looks like something in toolkit now depends on it,
> which is wrong.
So if it's wrong as you say, what are we're going to do about it? Complain to the author of bug 1238183?

Comment 3

[aleth [:aleth]]

(In reply to Jorg K (GMT+2, PTO during summer, NI me) from comment #2)
> So if it's wrong as you say, what are we're going to do about it? Complain
> to the author of bug 1238183?

See bug 1238183 Comment 69

Comment 4

[Jorg K (CEST = GMT+2)]

Fixed by bug 1285889.