Closed
Bug 1285889
Opened 8 years ago
Closed 8 years ago
Moving the ContextualIdentityService.jsm from browser/components/contextualidentity into tookit/components/contextualidentity
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: timhuang, Assigned: timhuang)
References
(Blocks 1 open bug)
Details
(Whiteboard: [userContextId][domsecurity-active][uplift49-])
Attachments
(1 file, 2 obsolete files)
Because some modules, the ForgetAboutSite and the Page thumbnail, in toolkit/ depend on the ContextualIdentityService. So we move the ContextualIdentityService.jsm into the toolkit/ to allow files in the toolkit/ can access this file.
|
||
Updated•8 years ago
|
Whiteboard: [userContextId][domsecurity-backlog] → [userContextId][domsecurity-active]
|
Assignee | |
Comment 1•8 years ago
|
||
Move the ContextualIdentityService.jsm, and also remove the dependency of browser/ of certain xpcshell tests that added in the Bug 1238183.
Attachment #8769728 -
Flags: review?(amarchesini)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8769728 [details] [diff] [review] Moving the ContextualIdentityService.jsm from from browser/components/contextualidentity into tookit/components/contextualidentity. Review of attachment 8769728 [details] [diff] [review]: ----------------------------------------------------------------- lgtm! ::: toolkit/components/contextualidentity/moz.build @@ +8,5 @@ > + 'ContextualIdentityService.jsm', > +] > + > +with Files('**'): > + BUG_COMPONENT = ('Firefox', 'Contextual Identity') These 2 lines should not be needed. This directory contains only ContextualIdentityService.jsm, right?
Attachment #8769728 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Yes, so this patch remove these lines. Thanks, baku.
Attachment #8769928 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8769728 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8769928 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d338a62e527d
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/adea33038173 Moving the ContextualIdentityService.jsm from from browser/components/contextualidentity into tookit/components/contextualidentity. r=baku
Keywords: checkin-needed
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/adea33038173
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Updated•8 years ago
|
Whiteboard: [userContextId][domsecurity-active] → [userContextId][domsecurity-active][uplift49-]
You need to log in
before you can comment on or make changes to this bug.
Description
•