1286036 - 2,000 instances of "NS_ENSURE_SUCCESS(status, status) failed with result 0x805303F4" emitted from netwerk/protocol/http/nsCORSListenerProxy.cpp during linux64 debug testing

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Eric Rahm [:erahm]]

> 1740 WARNING: NS_ENSURE_SUCCESS(status, status) failed with result 0x805303F4: file netwerk/protocol/http/nsCORSListenerProxy.cpp, line 553

This warning [1] shows up in the following test suites:

>    638 - [TC] Linux64 mochitest-plain-e10s-6 6
>    638 - [TC] Linux64 mochitest-6 6
>     95 - [TC] Linux64 mochitest-5 5
>     95 - [TC] Linux64 mochitest-plain-e10s-5 5
>     83 - [TC] Linux64 web-platform-tests-e10s-4 4
>     75 - [TC] Linux64 web-platform-tests-4 4
>     31 - [TC] Linux64 web-platform-tests-e10s-3 3
>     31 - [TC] Linux64 web-platform-tests-3 3
>     16 - [TC] Linux64 mochitest-plain-e10s-2 2
>     16 - [TC] Linux64 mochitest-2 2
>      9 - [TC] Linux64 mochitest-7 7
>      4 - [TC] Linux64 web-platform-tests-2 2
>      4 - [TC] Linux64 web-platform-tests-e10s-2 2
>      2 - [TC] Linux64 web-platform-tests-e10s-9 9
>      2 - [TC] Linux64 web-platform-tests-9 9
>      1 - [TC] Linux64 mochitest-plain-e10s-7 7

It shows up in 54 tests. A few of the most prevalent:

>    212 -        dom/tests/mochitest/fetch/test_fetch_cors_sw_reroute.html
>    212 - [e10s] dom/tests/mochitest/fetch/test_fetch_cors_sw_reroute.html
>    212 -        dom/tests/mochitest/fetch/test_fetch_cors_sw_empty_reroute.html
>    212 - [e10s] dom/tests/mochitest/fetch/test_fetch_cors_sw_empty_reroute.html
>    201 -        dom/tests/mochitest/fetch/test_fetch_cors.html
>    201 - [e10s] dom/tests/mochitest/fetch/test_fetch_cors.html
>     59 - [e10s] dom/security/test/cors/test_CrossSiteXHR.html
>     59 -        dom/security/test/cors/test_CrossSiteXHR.html
>     40 - [e10s] /fetch/api/cors/cors-redirect-credentials.html
>     40 -        /fetch/api/cors/cors-redirect-credentials.html

[1] https://hg.mozilla.org/mozilla-central/annotate/214884d507ee/netwerk/protocol/http/nsCORSListenerProxy.cpp#l553

Comment 1

[Eric Rahm [:erahm]]

Bisection points to bug 1279991, bug 1279324, or bug 1274868 [1]. I'm guessing it's bug 1279324.

[1] https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c34ec3e0884c31f128cf051619e78ffd9461a1c4&tochange=3d0a326d219435e00ea597b10260d4cfeebe5c96

Comment 2

[Josh Matthews [:jdm]]

It's interesting to me that the line at fault occurs earlier in execution than the lines that bug 1279324 added to that method. I'm not sure what to make of that; maybe we're suddenly causing a bunch of preflights in tests to fail now.

Comment 3

[Eric Rahm [:erahm]]

(In reply to Josh Matthews [:jdm] from comment #2)
> It's interesting to me that the line at fault occurs earlier in execution
> than the lines that bug 1279324 added to that method.

Ah good point, I think the line normalization in my bisection code might be messed up. I'll take a look and re-run.

Comment 4

[Decky Coss (:deckycoss)]

i have run some of the tests you listed with and without my patch and i'm failing to see an increase in the number of nsCORSListenerProxy warnings between the two.

here are the exact steps i took:

1. ./mach mochitest dom/tests/mochitest/fetch/test_fetch_cors_sw_reroute.html &> log_with_patch.txt
2. hg backout -r e5387a7d0920 --no-commit
3. ./mach build binaries
4. ./mach mochitest dom/tests/mochitest/fetch/test_fetch_cors_sw_reroute.html &> log_without_patch.txt

log_with_patch.txt contain 212 instances of "WARNING: NS_ENSURE_SUCCESS(status, status) failed with result 0x805303F4: file /home/decky/src/mozilla-central/netwerk/protocol/http/nsCORSListenerProxy.cpp, line 553". log_without_patch.txt contains the same number (when the line number is corrected).

i repeated these steps for dom/tests/mochitest/fetch/test_fetch_cors_sw_empty_reroute.html and /fetch/api/cors/cors-redirect-credentials.html with analogous results.

here's a diff of the backout: https://gist.github.com/deckycoss/83e8e677b33db6e33d056262a492f550

Comment 5

[Eric Rahm [:erahm]]

The script was indeed confused by the line number changes, sorry for the confusion (unfortunately normalization isn't an option here due to how generic the warning is, it's used other places in the same file). Apparently this warning has been around since as far as I can bisect (2016-04-01).

So there's still a bunch of warnings, but not because of bug 1279324.

Comment 7

[Eric Rahm [:erahm]]

This continues to be a top warning and has become somewhat more verbose.

Comment 8

[Eric Rahm [:erahm]]

Attachment: Stop warning if a network request failed

In bug 1152574 we stopped warning in the web console but started warning in the
console instead. This removes that warning as well.

Patrick, feel free to redirect.

MozReview-Commit-ID: 2TYUngN8DBW

Comment 9

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a79f4aaa4be112e6e0fad32d469609ccfd17517
Bug 1286036 - Stop warning if a network request failed. r=mcmanus

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a79f4aaa4be