1288966 - Build contains 2 identical files "seamonkey" and "seamonkey-bin" -- port fix for Bug 658850 to SM

Status: NEW

(SeaMonkey :: Build Config, defect)

Description

[Rainer Bielefeld]

from <http://archive.mozilla.org/pub/seamonkey/nightly/latest-comm-central-trunk/> I downloaded and unzipped a Linux build Version=2.47a1
BuildID=20160722003002 SourceStamp=2e3390571fdb3a1ff3d2f7f828adf67dbc237bc8.

Contains bit by bit identical (?) files "seamonkey" and "seamonkey-bin". I did a test with a different Version on an UBUNTU virtual machine:
1. Renamed "seamonkey" to "_X_seamonkey"
2. Launched SeaMonkey via link to "seamonkey-bin". 
   » no problem observed with a quick test with email client, browser and 
     chatzilla
3. Terminated SeaMonkey
10. Renamed "_X_seamonkey" back to "seamonkey"
11. Renamed "seamonkey-bin" to "_X_seamonkey-bin"
12. Launched SeaMonkey via link to "seamonkey". 
   » no problem observed with a quick test with email client, browser and 
     chatzilla

So one of these twin-files seems to be superfluous? 

a) This issue has been found by [e-mail]  at
   Bug 1089324 comment #4.
b) I think this one is much older than 2.47

@alister.hood:
Can you confirm my observations? With what SeaMonkey Version did you observe this issue?

Comment 1

[Frank-Rainer Grahl (:frg)]

This has been true for ages. Even Firefox does it this way. You might need to ask one of the linux build experts in irc for an explanation. 

https://dxr.mozilla.org/comm-central/source/suite/installer/package-manifest.in

>> ...
>> #else
>> @BINPATH@/@MOZ_APP_NAME@-bin
>> @BINPATH@/@MOZ_APP_NAME@
>> ...

Doubt its a bug. I think it might just be here for backward compatibility these days.

Comment 2

[Rainer Bielefeld]

b): Started in the 2.10 area:

b1) seamonkey, seamonkey-bin: twins with few hundred KB
    * BuildID=20130803195701; Milestone=23.0; SourceStamp=6337621c540c (743 KB)
    * BuildID=20120604225847; Milestone=13.0: SourceStamp=2b643ea8edf9 (95 KB)

b2) seamonkey: Script 4KB; seamonkey-bin : binary 17.6 MB (or similar)
    ## This script is meant to run the application binary from mozilla/dist/bin.
    ## The script will setup all the environment voodoo needed to make
    ## the application binary to work.
    * BuildID=20120422224137; Milestone=12.0; SourceStamp=a294a5b4f12d
    * BuildID=20120129115312; Milestone=10.0; SourceStamp=3851ce93e81f
    * BuildID=20111121023255; Milestone=8.0.1; SourceStamp=463b6cbdef7c
    * BuildID=20110606000022; Milestone=1.9.1.20pre; SourceStamp=5eb1fd50c7ad

Comment 3

[Rainer Bielefeld]

(In reply to Frank-Rainer Grahl from comment #1)
c) Yes, also FF 2.47 (and probably older ones) contains "firefox" + "firefox-bin"
   with identical size 
   So this one seems to be a DUP of "Bug 658850 - Avoid duplicating 
   "firefox" as "firefox-bin""

Comment 4

[Rainer Bielefeld]

A am not sure whether Build-Config-bugs will find their way into SM automatically, so I think this one might have some right to exist as a tracking bug for SM

Comment 5

[Edmund Wong (:ewong)]

Attachment: bustage-fix.patch

This was submitted offline by Bill...

Comment 6

[Edmund Wong (:ewong)]

Comment on attachment 8961986 [details] [diff] [review]
bustage-fix.patch

Review of attachment 8961986 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/app/Makefile.in
@@ +53,5 @@
>  endif
>  
>  ifneq ($(OS_ARCH),WINNT)
>  
>  libs:: 

there's a trailing whitespace.

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8961986 [details] [diff] [review]
bustage-fix.patch

I am moving this patch over to a new bug 1448543.

Comment 8

[Rainer Bielefeld]

From WG9s SeaMonkey 2.57 Builds I downloaded
seamonkey-2.57a1pre.en-US.linux-i686.tar.bz2 2022-06-14 14:21 46M Linux-32 and
seamonkey-2.57a1pre.en-US.linux-x86_64.tar.bz2 2022-06-14 14:21 51M Linux-64

Still see those 2 very similar files. Exactly the same size on HDD, eventually minimum differences in contents.