1288971 - The icon on the media control is out of sync

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[William Hsu [:whsu]]

Attachment: ICON_ON_MEDIA_CONTROL_0725.png

@ Environment: 
  Device: Nexus 5 (Android 5.1.1);
  Build: Nightly 50.0a1 (2016-07-19);

@ Steps to reproduce:
  1. Open Firefox, and then got to "www.youtube.com" to play a video
  2. Press home button
  3. Open Google Chrome, and then go to "www.youtube.com"
  4. Play a video on Google Chrome, and then use app switch button to switch to Firefox
  5. Press play button to continue to play the same video on Firefox
  6. Swipe down the notification bar to check the status of media control

@ Expected result:
  The video can be played and the icon on the media control is shown as "PAUSE[||]".

@ Actual result:
  The icon on the media control is shown as "PLAY[>]".

@ Note: Attach the screenshot (ICON_ON_MEDIA_CONTROL_0725.png)

Comment 1

[Rachelle Yang [:ryang][[e-mail]]]

Hi Alastor, 

Could you please kindly help us check this ?
Thank you very much !

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1288971 - notify audio playback changed by media element's play().

Review commit: https://reviewboard.mozilla.org/r/67932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67932/

Comment 4

[Alastor Wu [:alwu]]

Comment on attachment 8775884 [details]
Bug 1288971 - notify audio playback changed by media element's play().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67932/diff/1-2/

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8775884 [details]
Bug 1288971 - notify audio playback changed by media element's play().

https://reviewboard.mozilla.org/r/67932/#review65072

Comment 6

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0e4d6e69394&selectedJob=24762407

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf3d0b086060
notify audio playback changed by media element's play(). r=baku

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cf3d0b086060

Comment 9

[Alastor Wu [:alwu]]

Comment on attachment 8775884 [details]
Bug 1288971 - notify audio playback changed by media element's play().

Approval Request Comment
[Feature/regressing bug #]: Let the media control interface can be consistent with the media element's playing state.
[User impact if declined]: Media control would be inconsistent.
[Describe test coverage new/current, TreeHerder]: No UI test
[Risks and why]: Low, this patch would only affect the control interface.
[String/UUID change made/needed]: no

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Now that the feature is behind a Nightly flag you do not necessarily need to request uplift everywhere. As soon as everything is fixed we just remove the flag for the current version and let the changes ride the trains. This will give us some additional testing time too.

Comment 11

[Sorina Florean [:sflorean]]

Verified as fixed in build 51.0a1 2016-08-05;
Device: LG G4 (Android 5.1).

Comment 12

[Alex Caziuc]

I'm changing the status to verified fixed considering that the bug is verified.