1289356 - Media actions are inconsistent after pressing Home

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P2)

Description

[Cynthia Tang [:cynthiatang]]

Test case1:
1. Launch Firefox app
2. Go to www.youtube.com and play video 1
3. Launch Chrome app and play video 2
4. Press Home 

Actual:
- The video 1 will be played in Firefox

Test case2:
1. Launch Firefox app
2. Go to www.youtube.com and play video 1
3. Launch Youtube app and play video 3
4. Press Home 

Actual:
- No video will be played

Device: Nexus 5
Android: 6.0.1
Firefox: 49.0a2 (2016-07-25)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Comparing this with other apps (Google Music, Amazon Music, TuneIn) none of the other apps automatically resumes playback in test case 1.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1289356 - only resume music when we're in the state 'AUDIOFOCUS_LOSS_TRANSIENT'.

Review commit: https://reviewboard.mozilla.org/r/67892/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67892/

Comment 3

[Alastor Wu [:alwu]]

Comment on attachment 8775844 [details]
Bug 1289356 - only resume music when we're in the state 'AUDIOFOCUS_LOSS_TRANSIENT'.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67892/diff/1-2/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8775844 [details]
Bug 1289356 - only resume music when we're in the state 'AUDIOFOCUS_LOSS_TRANSIENT'.

https://reviewboard.mozilla.org/r/67892/#review65070

Comment 5

[Alastor Wu [:alwu]]

It's the fastest review response I have ever seen :D
Thanks!

--

https://treeherder.mozilla.org/#/jobs?repo=try&revision=592ce77fc549

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f171516dfc2
only resume music when we're in the state 'AUDIOFOCUS_LOSS_TRANSIENT'. r=sebastian

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2f171516dfc2

Comment 8

[Alastor Wu [:alwu]]

Comment on attachment 8775844 [details]
Bug 1289356 - only resume music when we're in the state 'AUDIOFOCUS_LOSS_TRANSIENT'.

Approval Request Comment
[Feature/regressing bug #]: The audio wouldn't be resumed at the wrong moment
[User impact if declined]: The audio would be resumed unexpectedly
[Describe test coverage new/current, TreeHerder]: No UI test 
[Risks and why]: Low, it only affects the resuming behavior.
[String/UUID change made/needed]: No

Comment 9

[Sorina Florean [:sflorean]]

Verified as fixed in build 51.0a1 2016-08-08;
Device: Nexus 5 (Android 6.0.1).

Comment 10

[Alex Caziuc]

Verified as fixed using the test cases from description on Aurora 50.0a2(2016-09-01) with Galaxy Note 5(6.0.1).