Fix timeout issues in Places.remove_all_history()

NEW
Unassigned

Status

Testing
Firefox UI Tests
P5
normal
2 years ago
5 months ago

People

(Reporter: whimboo, Unassigned)

Tracking

(Blocks: 3 bugs, {meta})

Version 3
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

There is a hang in execute_script() for `remove_all_history()`:
https://dxr.mozilla.org/mozilla-central/source/testing/puppeteer/firefox/firefox_puppeteer/api/places.py?q=places.py&redirect_type=direct#109

(In reply to Marco Bonardo [::mak] from bug 1284119 comment #2)
> (In reply to Henrik Skupin (:whimboo) from comment #1)
> > Our timeout is 10s. Marco, do you think that we should bump that up? I
> > actually don't think so given that the number of history items is still low
> > at this point.
> 
> It should be a problem only with a quite large history or if you are
> removing History while there's an history view visible on the screen (the
> history sidebar or the Library in the history view).
> Or maybe the disk is so busy on the box that it delays everything by seconds?
> 
> If you can reproduce such an hang locally, it may help, but off-hand I have
> no idea, it should really take more then a few ms if you have just a few
> history entries.

In our case we have a timeout of 10s set and the history has only some items contained.

I will make this bug blocking all the other known test failures, given that multiple tests are busted due to that behavior.
Blocks: 1414585
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.