1289115 - Fix timeout issues in Places.remove_all_history()

Status: RESOLVED INVALID

(Testing :: Firefox UI Tests, defect, P5)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There is a hang in execute_script() for `remove_all_history()`:
https://dxr.mozilla.org/mozilla-central/source/testing/puppeteer/firefox/firefox_puppeteer/api/places.py?q=places.py&redirect_type=direct#109

(In reply to Marco Bonardo [::mak] from bug 1284119 comment #2)
> (In reply to Henrik Skupin (:whimboo) from comment #1)
> > Our timeout is 10s. Marco, do you think that we should bump that up? I
> > actually don't think so given that the number of history items is still low
> > at this point.
> 
> It should be a problem only with a quite large history or if you are
> removing History while there's an history view visible on the screen (the
> history sidebar or the Library in the history view).
> Or maybe the disk is so busy on the box that it delays everything by seconds?
> 
> If you can reproduce such an hang locally, it may help, but off-hand I have
> no idea, it should really take more then a few ms if you have just a few
> history entries.

In our case we have a timeout of 10s set and the history has only some items contained.

I will make this bug blocking all the other known test failures, given that multiple tests are busted due to that behavior.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:whimboo, maybe it's time to close this bug?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

meta was most likely set incorrectly. This bug blocks other intermittent bugs.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With the removal of the firefox-puppeteer package this library no longer exists.