1573383 - Remove firefox-puppeteer Python package

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The firefox-puppeteer package which can be found at /testing/marionette/puppeteer is mostly unmaintained, and the only consumer are probably the in-tree firefox-ui tests.

Now that the remote agent (our endpoint for Puppeteer) is being worked on, and Marionette client is already deprecated on mozilla-central, everything related to the Marionette Python ecosystem should be removed, or a replacement been found.

Consider this a meta bug and lets file dependencies.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that we haven't released any new version of firefox-puppeteer to PyPI during the last 3 years, we might want to simply deprecate this project on PyPI and remove it all together to have no name clashes with the upcoming (Google) Puppeteer support for Firefox. Also in the last three years has been changed so much, so I expect that most of the code from the 52 release is kinda broken on nowadays Firefox releases. If people are using it they will have to migrate to the code base in mozilla-central, which is similar to what we did with Marionette client.

Compared to Marionette I don't think it makes sense to keep this project further on PyPI, and I really would like to completely remove it. Andreas, and Maja do you have any objections for that destructive operation?

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

No objections.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that Andreas is not directly involved into the marionette firefox-puppeteer development and history, I went ahead and deleted the project on PyPI. At the same time I also removed the firefox-ui-harness package, which was dependent on it, and also hasn't been updated for more than 3 years.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1573383 - [firefox-puppeteer] Update docs for PyPI package deprecation. r=#webdriver a=docs

DONTBUILD

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9650c17fd977
[firefox-puppeteer] Update docs for PyPI package deprecation. r=webdriver-reviewers,maja_zf a=docs

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9650c17fd977

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I'm going to convert the remaining firefox-ui tests into plain Marionette tests. With that we no longer have a dependency on firefox-puppeteer, and we can remove this whole folder.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1573383 - [marionette] Allow to open a private browsing window.

Depends on D61511

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1573383 - [fxui] Remove no longer needed keyboard shortcut test.

Depends on D61683

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1573383 - [fxui] Remove firefox-puppeteer dependency from safebrowsing tests.

Depends on D61684

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1573383 - [fxui] Remove firefox-puppeteer dependency from sessionstore tests.

Depends on D61685

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1573383 - [marionette] Remove firefox-puppeteer Python package.

Depends on D61686

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Before can push the patches we will have to wait for the final review on bug 1573641. This might happen next week on the 13th.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59fc9156b2f5
[marionette] Allow to open a private browsing window. r=marionette-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/c9619f114626
[fxui] Remove no longer needed keyboard shortcut test. r=marionette-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/fa9eaa053015
[fxui] Remove firefox-puppeteer dependency from safebrowsing tests. r=marionette-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/4e5fa5bd9742
[fxui] Remove firefox-puppeteer dependency from sessionstore tests. r=marionette-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/7ff6cd9c01cd
[marionette] Remove firefox-puppeteer Python package. r=marionette-reviewers,maja_zf

Comment 16

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/59fc9156b2f5
https://hg.mozilla.org/mozilla-central/rev/c9619f114626
https://hg.mozilla.org/mozilla-central/rev/fa9eaa053015
https://hg.mozilla.org/mozilla-central/rev/4e5fa5bd9742
https://hg.mozilla.org/mozilla-central/rev/7ff6cd9c01cd

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://firefox-puppeteer.readthedocs.io has also been removed now, which means that all necessary work has been done now.