1289679 - Support detection the Windows SDK 10

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

The autodetection code added in bug 1289291 only detects windows SDK 8.1.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1289679 - Support detecting Windows SDK 10.

Review commit: https://reviewboard.mozilla.org/r/67372/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67372/

Comment 2

[Mike Hommey [:glandium]]

Considering how the lib/ part of the SDK is yet different, and that I'm going to have to change how this works down the road, let's change how this works form the start.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8775026 [details]
Bug 1289679 - Support detecting Windows SDK 10.

https://reviewboard.mozilla.org/r/67372/#review64618

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/db3ed1fdbbea
Support detecting Windows SDK 10. r=chmanchester, a=me

Comment 6

[Mike Hommey [:glandium]]

(In reply to Pulsebot from comment #5)
> Pushed by [e-mail]:
> https://hg.mozilla.org/mozilla-central/rev/db3ed1fdbbea
> Support detecting Windows SDK 10. r=chmanchester, a=me

Just noticed that while doing a git log, and feeling weird when I saw a=me with me being the author, and thinking wtf. This was really a=ryanvm.