1289291 - Move Windows SDK detection to python configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1289291 - Set WINDOWSSDKDIR as a Windows path instead of msys path.

Review commit: https://reviewboard.mozilla.org/r/67086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67086/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1289291 - Move Windows SDK detection to python configure.

At the same time, autodetect the SDK if WINDOWSSDKDIR is not given.

Review commit: https://reviewboard.mozilla.org/r/67088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67088/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8774630 [details]
Bug 1289291 - Set WINDOWSSDKDIR as a Windows path instead of msys path.

https://reviewboard.mozilla.org/r/67086/#review64292

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8774631 [details]
Bug 1289291 - Move Windows SDK detection to python configure.

https://reviewboard.mozilla.org/r/67088/#review64294

::: build/moz.configure/windows.configure:16
(Diff revision 1)
> -@depends_when('--with-windows-version', when=is_windows)
> +@template
> +def depends_win(*args):
> +    return depends_when(*args, when=is_windows)

Can we conditionally include this whole file?

::: build/moz.configure/windows.configure:43
(Diff revision 1)
> +    if host.kernel != 'WINNT':
> +        return ()

Will this ever be the case, considering depends_win?

::: build/moz.configure/windows.configure:46
(Diff revision 1)
> +    if value:
> +        return value
> +    if host.kernel != 'WINNT':
> +        return ()
> +
> +    return tuple(x[1] for x in get_registry_values(

Where is `get_registry_values` defined?

Comment 5

[Mike Hommey [:glandium]]

https://reviewboard.mozilla.org/r/67088/#review64294

> Can we conditionally include this whole file?

Unfortunately not, because target/host do not depend on --help.

> Will this ever be the case, considering depends_win?

depends_win is target.kernel == 'WINNT'. This test is for host.kernel != 'WINNT'. The difference is for cross-builds (windows builds on linux host)

> Where is `get_registry_values` defined?

Bug 1289286, which just landed.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8774631 [details]
Bug 1289291 - Move Windows SDK detection to python configure.

https://reviewboard.mozilla.org/r/67088/#review64330

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be8b0845f283
Set WINDOWSSDKDIR as a Windows path instead of msys path. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/656febbe6d05
Move Windows SDK detection to python configure. r=chmanchester

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be8b0845f283
https://hg.mozilla.org/mozilla-central/rev/656febbe6d05