1289824 - Add "missing talos" jobs for TaskCluster jobs

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Armen [:armenzg]]

Once we have Talos jobs running on Treeherder we will want the ability to trigger any missing talos jobs as we can do now for Buildbot jobs.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I assume the jobs will be running in TaskCluster, which requires hardware (and I expect there's a bug out there somewhere representing that project?).

As I understand it, this bug is a *treeherder* bug to allow backfilling those jobs?  How is it different from bug 1289823?

Comment 2

[Armen [:armenzg]]

Two different methods.

One of them trasverses revisions for a specific job.
This one add all talos jobs for a specific revision.

Comment 3

[Armen [:armenzg]]

Removing pulse_actions from the bug summary since this might be implemented under taskcluster-treeherder.

Comment 5

[Brian Stack [:bstack]]

Attachment: Bug 1289824 - Add "add-talos" taskgraph action

Review commit: https://reviewboard.mozilla.org/r/103912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103912/

Comment 6

[Brian Stack [:bstack]]

Comment on attachment 8825838 [details]
Bug 1289824 - Add "add-talos" taskgraph action

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103912/diff/1-2/

Comment 7

[Chris Cooper [:coop] (he/him)]

Is this still blocking our push to tier 1 for Linux/Android next week?

Comment 8

[Brian Stack [:bstack]]

As I understand it, this does not block anything since it is just a convenience. I want to finish this by next week regardless, so it might not be an issue either way.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

this will not be a blocker, but it is a huge time saver

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

I'm going to remove this from the migration flowchart, then.  I trust that Joel will make sure we get it done :)

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

this is still important to get done, it is a commonly used sheriffing feature that buildbot supports and taskcluster does not.  Please leave it on the list of things to resolve as part of the migration.

Comment 12

[Brian Stack [:bstack]]

This is being worked on actively. Just wading through treeherder and pulse_actions now.

Comment 13

[GitHub Autolander Bot]

Attachment: [treeherder] imbstack:bug-1289824 > mozilla:master

Comment 14

[Brian Stack [:bstack]]

Once these two patches are in good shape, we can land them (gecko change first). As I understand it, we still want to trigger pulse_action so that it can start the buildbot talos jobs, and also submit a tc action task for creating the tc talos jobs. If that's a misunderstanding, I'm happy to go back in and change how this works. There's an example of this in-progress (at the moment) on https://treeherder.mozilla.org/#/jobs?repo=try&revision=96994dc4b558f04c8de01751297f2dc9b87ae22f (I'm pretty sure the failed build isn't related to this, but I'll look into it a bit more).

Comment 15

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8825838 [details]
Bug 1289824 - Add "add-talos" taskgraph action

https://reviewboard.mozilla.org/r/103912/#review107526

so this only works from mach, or does it plug into treeherder like the backfill button?

Comment 16

[Brian Stack [:bstack]]

Comment on attachment 8825838 [details]
Bug 1289824 - Add "add-talos" taskgraph action

https://reviewboard.mozilla.org/r/103912/#review107526

Soon as somebody ships https://github.com/mozilla/treeherder/pull/2092, it will work from treeherder.

Comment 17

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8825838 [details]
Bug 1289824 - Add "add-talos" taskgraph action

https://reviewboard.mozilla.org/r/103912/#review107534

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Autoland couldn't rebase this for landing.

Comment 19

[Brian Stack [:bstack]]

Comment on attachment 8825838 [details]
Bug 1289824 - Add "add-talos" taskgraph action

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103912/diff/2-3/

Comment 20

[Brian Stack [:bstack]]

Sorry about that. I've rebased onto m-c. Hopefully it works this time around!

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28912d8b6b3a
Add "add-talos" taskgraph action r=jmaher

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/28912d8b6b3a

Comment 23

[Cameron Dawson [:camd]]

Comment on attachment 8828974 [details] [review]
[treeherder] imbstack:bug-1289824 > mozilla:master

I requested a couple small changes, but with those, this is ready to go.  Would you just document here in the bug the testing you did for this so we have it?

Thanks!!

Comment 24

[Cameron Dawson [:camd]]

bstack: OK, I've approved those changes.  Would you like to merge this, or have me do it?   :)

Comment 25

[Brian Stack [:bstack]]

I don't think I have the permissions necessary to merge it! Thanks for the help :)

Comment 26

[Chris Cooper [:coop] (he/him)]

(In reply to Brian Stack [:bstack] from comment #25)
> I don't think I have the permissions necessary to merge it! Thanks for the
> help :)

Tagging :camd directly for this.

Comment 27

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e438c9fc45a177cbfca887ef3bdf4c0c8bbfd505
Bug 1289824 - Add add-all-talos support directly to tc (#2092)

Comment 28

[Cameron Dawson [:camd]]

Ok, this has now been merged.  Thanks for the n-i, coop.  :)

Comment 29

[William Lachance (:wlach)]

Unfortunately landing this broke perfherder and the logviewer, because it added a dependency on taskcluster to the logviewer. I have a fix.

Comment 30

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1289824-fixup > mozilla:master

Comment 31

[William Lachance (:wlach)]

Comment on attachment 8835561 [details] [review]
[treeherder] wlach:1289824-fixup > mozilla:master

Hi Brian, unfortunately your changes broke some stuff because it introduced a new dependency on the resultset service that required updates to perfherder and the logviewer. :( Not your fault really, we need better automated tests around the UI. Anyway, the fix is simple. Figured you'd be fine to review it.

Comment 32

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/91dd1846f8061eeb8b83705f1d3a23e013c0a7c7
Bug 1289824 - Fix perfherder and logviewer (#2150)

Comment 33

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.