1290629 - nightly 20160729 compile fails without webrtc, fatal error: webrtc/video_engine/include/vie_capture.h: No such file or directory

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[u532768]

Attachment: The .mozconfig that I am using to compile nightly.

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160728170116

Steps to reproduce:

Update local hg repository for nightly, then compile it.  


Actual results:

4:55.45 In file included from /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/layout/generic/Unified_cpp_layout_generic1.cpp:65:0:
 4:55.45 /mnt/to_archive/accum/src/mozilla-central/layout/generic/nsFlexContainerFrame.cpp: In member function ‘void nsFlexContainerFrame::DoFlexLayout(nsPresContext*, nsIFrame::ReflowOutput&, const ReflowInput&, nsReflowStatus&, nscoord,
 nscoord, nsTArray<nsFlexContainerFrame::StrutInfo>&, const nsFlexContainerFrame::FlexboxAxisTracker&)’:
 4:55.45 Warning: -Wmaybe-uninitialized in /mnt/to_archive/accum/src/mozilla-central/layout/generic/nsFlexContainerFrame.cpp: ‘flexContainerAscent’ may be used uninitialized in this function
 4:55.45 /mnt/to_archive/accum/src/mozilla-central/layout/generic/nsFlexContainerFrame.cpp:4201:3: warning: ‘flexContainerAscent’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 4:55.45    if (flexContainerAscent == nscoord_MIN) {
 4:55.46    ^~
 4:57.48 In file included from /mnt/to_archive/accum/src/mozilla-central/dom/media/webrtc/MediaEngineDefault.h:21:0,
 4:57.48                  from /mnt/to_archive/accum/src/mozilla-central/dom/media/webrtc/MediaEngineDefault.cpp:5,
 4:57.48                  from /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dom/media/webrtc/Unified_cpp_dom_media_webrtc0.cpp:2:
 4:57.48 /mnt/to_archive/accum/src/mozilla-central/dom/media/webrtc/MediaEngineCameraVideoSource.h:14:53: fatal error: webrtc/video_engine/include/vie_capture.h: No such file or directory
 4:57.48  #include "webrtc/video_engine/include/vie_capture.h"
 4:57.48                                                      ^
 4:57.48 compilation terminated.
 4:57.49 
 4:57.49 In the directory  /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dom/media/webrtc
 4:57.49 The following command failed to execute properly:
 4:57.49 /usr/bin/ccache /usr/lib64/ccache/g++ -std=gnu++11 -o Unified_cpp_dom_media_webrtc0.o -c -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/stl_wrappers -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64
-pc-linux-gnu/dist/system_wrappers -include /mnt/to_archive/accum/src/mozilla-central/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/mnt/to_archive/accum/src/mozilla-central/dom/media/webrtc -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dom/media/webrtc -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders -I/mnt/to_archive/accum/src/mozilla-central/ipc/chromium/src -I/mnt/to_archive/accum/src/mozilla-central/ipc/glue -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/include -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/include/nspr -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/mozilla-config.h -MD -MP -MF .deps/Unified_cpp_dom_media_webrtc0.o.pp -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wc++14-compat -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -Wall -fno-schedule-insns2 -fno-lifetime-dse -fno-delete-null-pointer-checks -O3 -fomit-frame-pointer -Wno-error=attributes -Wno-error=shadow /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dom/media/webrtc/Unified_cpp_dom_media_webrtc0.cpp
 4:57.49 /mnt/to_archive/accum/src/mozilla-central/config/rules.mk:934: recipe for target 'Unified_cpp_dom_media_webrtc0.o' failed
 4:57.49 gmake[5]: *** [Unified_cpp_dom_media_webrtc0.o] Error 1
 4:57.49 /mnt/to_archive/accum/src/mozilla-central/config/recurse.mk:71: recipe for target 'dom/media/webrtc/target' failed
 4:57.49 gmake[4]: *** [dom/media/webrtc/target] Error 2
 4:57.49 gmake[4]: *** Waiting for unfinished jobs....



Expected results:

PASS
PASS

Comment 1

[u532768]

This seems to be a regression to https://bugzilla.mozilla.org/show_bug.cgi?id=1255217

And it arose after the fix for this bug, https://bugzilla.mozilla.org/show_bug.cgi?id=1284726 went in recently.

As a workaround, I've been enabling webrtc, and then nightly compiles fine.  But I'd rather not have webrtc enabled, since I don't use it.

Comment 2

[Tooru Fujisawa [:arai]]

this is a regression from bug 1286096, the following changeset.
https://hg.mozilla.org/mozilla-central/rev/ca07b7baf290

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1290629 - Make default cam, which is supposed to model a real cam, nonetheless independent of webrtc includes.

Review commit: https://reviewboard.mozilla.org/r/68360/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68360/

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1290629 - Make default cam, which is supposed to model a real cam, nonetheless independent of webrtc includes.

Review commit: https://reviewboard.mozilla.org/r/68386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68386/

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8776658 [details]
Bug 1290629 - Make default cam, which is supposed to model a real cam, nonetheless independent of webrtc includes.

https://reviewboard.mozilla.org/r/68360/#review65682

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8776678 [details]
Bug 1290629 - Make default cam, which is supposed to model a real cam, nonetheless independent of webrtc includes.

https://reviewboard.mozilla.org/r/68386/#review65684

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c74f4ce68ffe
Make default cam, which is supposed to model a real cam, nonetheless independent of webrtc includes. r=jesup

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c74f4ce68ffe

Comment 9

[u532768]

Originally opened the ticket.  Confirming that this fix works for me.  Thank you.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8776678 [details]
Bug 1290629 - Make default cam, which is supposed to model a real cam, nonetheless independent of webrtc includes.

Approval Request Comment
[Feature/regressing bug #]: unsure exactly

[User impact if declined]: Inability to build with --disable-webrtc (used by Tor)

[Describe test coverage new/current, TreeHerder]: We don't make --disable-webrtc builds.  Manually tested on linux

[Risks and why]: No risk.  Only affects whether it builds or not, and only with an option we don't use for our builds.  NPOTB

[String/UUID change made/needed]: none

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8776678 [details]
Bug 1290629 - Make default cam, which is supposed to model a real cam, nonetheless independent of webrtc includes.

Looks like it was caused by bug 1286096

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8776678 [details]
Bug 1290629 - Make default cam, which is supposed to model a real cam, nonetheless independent of webrtc includes.

NPOTB, Beta50+

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-release/rev/b57f380de3f2da0af0b57142b554a851496bf83a

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

 https://hg.mozilla.org/releases/mozilla-beta/rev/24b8f08f7756

This may be incorrect... if the tree has already moved to release.

Comment 15

[Junior [inactive]]

Attachment: Bug 1280629 - Part 1: Suspend the http channel if the child process is not able to consume on time