Last Comment Bug 1291320 - Marionette does not wait for load event when refreshing the document
: Marionette does not wait for load event when refreshing the document
Status: NEW
: ateam-marionette-server, ateam-marionette-spec
Product: Testing
Classification: Components
Component: Marionette (show other bugs)
: Version 3
: All All
P1 major with 1 vote (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
:
Mentors:
https://github.com/mozilla/geckodrive...
Depends on: 1333458
Blocks: webdriver
  Show dependency treegraph
 
Reported: 2016-08-02 09:15 PDT by Andreas Tolfsen
Modified: 2017-02-09 04:19 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description User image Andreas Tolfsen 2016-08-02 09:15:20 PDT
Marionette does not listen for onDOMContentLoad events when navigating backwards, forwards, or refreshing.  This is causing tests that use these API calls to be flaky.
Comment 1 User image Henrik Skupin (:whimboo) [away 02/18 - 02/27] 2016-08-03 02:13:35 PDT
The underlying issue here is that the pages are getting loaded from bfcache. So as you noticed we do not see those page events.
Comment 2 User image Andreas Tolfsen 2016-10-28 05:16:13 PDT
This also happens for Element Click.
Comment 3 User image Andreas Tolfsen 2016-10-28 05:16:21 PDT
geckodriver tracking issue: https://github.com/mozilla/geckodriver/issues/308
Comment 4 User image Henrik Skupin (:whimboo) [away 02/18 - 02/27] 2017-02-02 04:36:24 PST
I feel this should wait for a solution on bug 1288336, so we know better what
could be done here. Andreas, David, what do you think?
Comment 5 User image Henrik Skupin (:whimboo) [away 02/18 - 02/27] 2017-02-02 04:43:31 PST
Well, the bug number I wanted to use should have been bug 1333458.
Comment 6 User image Andreas Tolfsen 2017-02-02 05:07:30 PST
As I commented on https://bugzilla.mozilla.org/show_bug.cgi?id=1335778, whichever is finished first can be rebased.  The scope of these bugs aren’t to change the behaviour of the current wait-for-page-to-load algorithm.
Comment 7 User image Henrik Skupin (:whimboo) [away 02/18 - 02/27] 2017-02-09 04:19:16 PST
(In reply to Andreas Tolfsen ‹:ato› from comment #6)
> As I commented on https://bugzilla.mozilla.org/show_bug.cgi?id=1335778,
> whichever is finished first can be rebased.  The scope of these bugs aren’t
> to change the behaviour of the current wait-for-page-to-load algorithm.

The current page load algorithm is kinda kinda bound to the get() method in listener.js. Given that this code will completely change via bug 1333458, I don't think it make sense to work on that code now, which gets thrown away soon again. Just my opinion.

Note You need to log in before you can comment on or make changes to this bug.