1292285 - Stylo Assertion failure: sheet->IsGecko() (GatherRuleProcessor must only be called for nsXBLPrototypeResources objects with Gecko-flavored style backends), at dom/xbl/nsXBLPrototypeResources.cpp:154

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Chris Peterson [:cpeterson]]

To reproduce, run `./mach reftest --disable-e10s <filename>` or replace <filename> with `layout/reftest/reftest.list`.

TEST-UNEXPECTED-FAIL | file:///home/shinglyu/workspace/stylo/gecko-dev/layout/reftests/webcomponents/input-transition-1.html | application terminated with exit code 11
REFTEST PROCESS-CRASH | file:///home/shinglyu/workspace/stylo/gecko-dev/layout/reftests/webcomponents/input-transition-1.html | application crashed [None]

Assertion failure: sheet->IsGecko() (GatherRuleProcessor must only be called for nsXBLPrototypeResources objects with Gecko-flavored style backends), at /files/mozilla/stylo/bb/gecko/dom/xbl/nsXBLPrototypeResources.cpp:154

Comment 1

[Matt Brubeck (:mbrubeck)]

The top of the stack is:

#01: nsXBLPrototypeResources::GatherRuleProcessor() (/home/mbrubeck/src/mozilla-central/dom/xbl/nsXBLPrototypeResources.cpp:151 (discriminator 1))
#02: nsXBLPrototypeResources::FlushSkinSheets() (/home/mbrubeck/src/mozilla-central/dom/xbl/nsXBLPrototypeResources.cpp:112)
#03: nsXBLPrototypeBinding::FlushSkinSheets() (/home/mbrubeck/src/mozilla-central/dom/xbl/nsXBLPrototypeBinding.cpp:257)
#04: mozilla::dom::ShadowRoot::StyleSheetChanged() (/home/mbrubeck/src/mozilla-central/dom/base/ShadowRoot.cpp:126)
#05: mozilla::StyleSheet::SetComplete() (/home/mbrubeck/src/mozilla-central/layout/style/StyleSheet.cpp:93)
#06: mozilla::css::Loader::DoSheetComplete(mozilla::css::SheetLoadData*, nsresult, nsTArray<RefPtr<mozilla::css::SheetLoadData> >&) (/home/mbrubeck/src/mozilla-central/layout/style/Loader.cpp:1898)
#07: mozilla::css::Loader::SheetComplete(mozilla::css::SheetLoadData*, nsresult) (/home/mbrubeck/src/mozilla-central/layout/style/Loader.cpp:1825)
#08: mozilla::css::Loader::ParseSheet(nsAString_internal const&, mozilla::css::SheetLoadData*, bool&) (/home/mbrubeck/src/mozilla-central/layout/style/Loader.cpp:1802)
#09: mozilla::css::Loader::LoadInlineStyle(nsIContent*, nsAString_internal const&, unsigned int, nsAString_internal const&, nsAString_internal const&, mozilla::dom::Element*, nsICSSLoaderObserver*, bool*, bool*) (/home/mbrubeck/src/mozilla-central/layout/style/Loader.cpp:2041)
#10: nsStyleLinkElement::DoUpdateStyleSheet(nsIDocument*, mozilla::dom::ShadowRoot*, nsICSSLoaderObserver*, bool*, bool*, bool) (/home/mbrubeck/src/mozilla-central/dom/base/nsStyleLinkElement.cpp:427)
#11: nsStyleLinkElement::UpdateStyleSheet(nsICSSLoaderObserver*, bool*, bool*, bool) (/home/mbrubeck/src/mozilla-central/dom/base/nsStyleLinkElement.cpp:223)
#12: nsHtml5DocumentBuilder::UpdateStyleSheet(nsIContent*) (/home/mbrubeck/src/mozilla-central/parser/html/nsHtml5DocumentBuilder.cpp:78)
#13: nsHtml5TreeBuilder::elementPopped(int, nsIAtom*, void*) (/home/mbrubeck/src/mozilla-central/parser/html/nsHtml5TreeBuilderCppSupplement.h:902)

Comment 2

[Matt Brubeck (:mbrubeck)]

This depends on shadow DOM support (bug 1293844).

Comment 3

[Bobby Holley (:bholley)]

Ok - can we convert this into a warning instead for now?

Comment 5

[Boris Zbarsky [:bzbarsky]]

> Ok - can we convert this into a warning instead for now?

Well, in an opt build it crashes.  This is also hitting dom/events/test/test_bug1145910.html

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Setting P1 per https://bugzilla.mozilla.org/show_bug.cgi?id=1323689#c2

Comment 9

[Bobby Holley (:bholley)]

We can mark any shadow-dom tests as skip-if stylo. Does this still reproduce on anything that doesn't explicitly pref-on shadow DOM?

Comment 10

[Boris Zbarsky [:bzbarsky]]

I would think it would also reproduce any time someone dispatches the "chrome-flush-skin-caches" observer notification.

Comment 11

[Boris Zbarsky [:bzbarsky]]

But also, some nightly users have shadow DOM enabled.  We should at the very least not crash in that configuration...

Comment 12

[Cameron McCormack (:heycam)]

Bug 1373155 disabled shadow DOM in document styled by Servo, so we should no longer be able to create a ShadowRoot and have the chrome-flush-skin-caches notification crash.

Comment 13

[Cameron McCormack (:heycam)]

I think this is fixed by bug 1373155.