CDMCaps still doesn't always consider output-restricted keys as usable

RESOLVED FIXED in Firefox 49

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed, firefox50 fixed, firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I discovered by inspection that I stuffed up bug 1289623, in that I think it's possible for us to hit an "output-restricted" key status, and not end up notifying decoding operations that are waiting for a key to become usable.

Potentially if we fix this, we could get EME playback stalls under some conditions.
(Assignee)

Comment 1

a year ago
Created attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

This is a follow up from bug 1289623, as I missed a few cases in that bug.

Review commit: https://reviewboard.mozilla.org/r/69874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69874/
Attachment #8778713 - Flags: review?(gsquelart)
Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

https://reviewboard.mozilla.org/r/69874/#review66980
Attachment #8778713 - Flags: review?(gsquelart) → review+

Comment 3

a year ago
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7e70c3b9830
Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases. r=gerald

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e7e70c3b9830
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Assignee)

Updated

a year ago
Blocks: 1277783
(Assignee)

Comment 5

a year ago
Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

Approval Request Comment
[Feature/regressing bug #]: Widevine EME on Linux
[User impact if declined]: The new Widevine CDM on Linux won't play Netflix.
[Describe test coverage new/current, TreeHerder]: We have plenty of EME mochitests, which run on Linux.
[Risks and why]: Low; this is just making what we consider to be a "usable" DRM key more permissive.
[String/UUID change made/needed]: None
Attachment #8778713 - Flags: approval-mozilla-beta?
Attachment #8778713 - Flags: approval-mozilla-aurora?

Updated

a year ago
status-firefox50: --- → affected
Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

Widevine EME on Linux, Aurora50+
Attachment #8778713 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

a year ago
status-firefox49: --- → affected
Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

Part of Widevine Linux support, uplift to beta.
Attachment #8778713 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(Assignee)

Comment 8

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/02110ecb55b9
status-firefox49: affected → fixed
(Assignee)

Comment 9

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/02110ecb55b9
https://hg.mozilla.org/releases/mozilla-aurora/rev/8988ea5b554cbed2b204eeb842ba643b3bf14bfc
status-firefox50: affected → fixed
You need to log in before you can comment on or make changes to this bug.