Closed Bug 1293101 Opened 4 years ago Closed 4 years ago

CDMCaps still doesn't always consider output-restricted keys as usable

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox49 --- fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I discovered by inspection that I stuffed up bug 1289623, in that I think it's possible for us to hit an "output-restricted" key status, and not end up notifying decoding operations that are waiting for a key to become usable.

Potentially if we fix this, we could get EME playback stalls under some conditions.
Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

https://reviewboard.mozilla.org/r/69874/#review66980
Attachment #8778713 - Flags: review?(gsquelart) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7e70c3b9830
Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases. r=gerald
https://hg.mozilla.org/mozilla-central/rev/e7e70c3b9830
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Blocks: 1277783
Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

Approval Request Comment
[Feature/regressing bug #]: Widevine EME on Linux
[User impact if declined]: The new Widevine CDM on Linux won't play Netflix.
[Describe test coverage new/current, TreeHerder]: We have plenty of EME mochitests, which run on Linux.
[Risks and why]: Low; this is just making what we consider to be a "usable" DRM key more permissive.
[String/UUID change made/needed]: None
Attachment #8778713 - Flags: approval-mozilla-beta?
Attachment #8778713 - Flags: approval-mozilla-aurora?
Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

Widevine EME on Linux, Aurora50+
Attachment #8778713 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

Part of Widevine Linux support, uplift to beta.
Attachment #8778713 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.