1293101 - CDMCaps still doesn't always consider output-restricted keys as usable

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I discovered by inspection that I stuffed up bug 1289623, in that I think it's possible for us to hit an "output-restricted" key status, and not end up notifying decoding operations that are waiting for a key to become usable.

Potentially if we fix this, we could get EME playback stalls under some conditions.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

This is a follow up from bug 1289623, as I missed a few cases in that bug.

Review commit: https://reviewboard.mozilla.org/r/69874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69874/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

https://reviewboard.mozilla.org/r/69874/#review66980

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7e70c3b9830
Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases. r=gerald

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e7e70c3b9830

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

Approval Request Comment
[Feature/regressing bug #]: Widevine EME on Linux
[User impact if declined]: The new Widevine CDM on Linux won't play Netflix.
[Describe test coverage new/current, TreeHerder]: We have plenty of EME mochitests, which run on Linux.
[Risks and why]: Low; this is just making what we consider to be a "usable" DRM key more permissive.
[String/UUID change made/needed]: None

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

Widevine EME on Linux, Aurora50+

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8778713 [details]
Bug 1293101 - Refactor CDMCaps.cpp to treat keys marked as output-restricted as usable in all cases.

Part of Widevine Linux support, uplift to beta.

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/02110ecb55b9

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/02110ecb55b9

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8988ea5b554cbed2b204eeb842ba643b3bf14bfc