1293837 - Move HAVE_64_BIT_BUILD test to python configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1293837 - Change try_compile() to return True when the test passes.

Currently, it returns either None or the contents of the compiler's stdout,
which is always expected to be an empty string, and is not very useful. So
instead, return True in the latter case.

Review commit: https://reviewboard.mozilla.org/r/70540/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70540/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1293837 - Move HAVE_64BIT_BUILD test to python configure.

Also, now that we're using modern C++11 compilers, we can just rely on
static_assert, instead of the pile of macros used in the autoconf test.

Review commit: https://reviewboard.mozilla.org/r/70546/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70546/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8779593 [details]
Bug 1293837 - Change try_compile() to return True when the test passes.

https://reviewboard.mozilla.org/r/70540/#review68086

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8779594 [details]
Bug 1293837 - Move HAVE_64BIT_BUILD test to python configure.

https://reviewboard.mozilla.org/r/70546/#review68088

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85f934cbd5fd
Change try_compile() to return True when the test passes. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/a23704e43d6c
Move HAVE_64BIT_BUILD test to python configure. r=chmanchester

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/926b40f1fb3a
Followup to fix 32-bit PGO builds r=me

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/85f934cbd5fd
https://hg.mozilla.org/mozilla-central/rev/a23704e43d6c
https://hg.mozilla.org/mozilla-central/rev/926b40f1fb3a