1293840 - Check that HAVE_64_BIT_BUILD result matches what we know of the target platform

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

We've had the HAVE_64_BIT_BUILD check forever, but we've never actually bothered checking its result matches our expectations considering the target CPU.

Comment 1

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #0)
> We've had the HAVE_64_BIT_BUILD check forever, but we've never actually
> bothered checking its result matches our expectations considering the target
> CPU.

Moreover, we have some things that use the value of HAVE_64BIT_BUILD even on artifact builds, but artifact builds don't run the test, so the value is wrong on 64-bits artifact builds. This bug should fix this at the same time.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1293840 - Determine HAVE_64BIT_BUILD from --target.

Until now, HAVE_64BIT_BUILD was entirely determined by a compiler check.
But we didn't run the check on e.g. artifact builds, while relying on
its result for some non-compilation related things, leading to subtle
discrepancies.

This changes the configure check to derive HAVE_64BIT_BUILD from bitness
determined by the target CPU, and double checked with a compiler check.

Review commit: https://reviewboard.mozilla.org/r/70550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70550/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8779600 [details]
Bug 1293840 - Determine HAVE_64BIT_BUILD from --target.

https://reviewboard.mozilla.org/r/70550/#review68092

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6a8a2c61740
Determine HAVE_64BIT_BUILD from --target. r=chmanchester

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f6a8a2c61740