1294926 - Write mochitests tests for the UI for editing events/tasks in a tab

Status: NEW

(Calendar :: Dialogs, defect, P5)

Description

[Paul Morris [:pmorris]]

There are currently mozmill tests for the window dialog for editing events/tasks.  Make versions of these tests for the tab UI for editing events/tasks (see bug 1277972).

Comment 1

[Markus Adrario [:Taraman]]

Should we make versions of all the event-Dialog tests for this, or is it sufficient that we have one test that demonstrates, that the integration of the dialog int the tab is working.

The iframe of the dialog stays the same after all...

Comment 2

[[:MakeMyDay]]

We probably don't need to test everything, since e.g. editing recurrences isn't different whether in tab or window mode.

What comes to mind as a good start (in descending order of importance) would be to test that

- switching between tab and window mode is working (bug 1321882)
- saving without closing works (bug 1297425)
- closing without saving works
- save & close works
- only writable events are opened in a tab (as long bug 1294924 isn't implemented)
- the menu items in File and Event&Task menus are working properly (see also bug 1321991)
- shortcuts are working (e.g. bug 1300845)
- timezone is displayed properly (bug 1302487)
- opening the same event twice doesn't open a second tab but moves the focus to the existing one (bug 1297423; not yet implemented)

Comment 3

[Markus Adrario [:Taraman]]

As I start work on this, one question arises:
Should we enable our shared modules to cope with in-tab editing, or is it sufficient to do it only for this test.

I would opt for the latter, since enabling the shared modules is a lot more work and I think it is enough to check the functionality in a single test.
If I find out, that it is simple to change, I might use the shared functions anyway.

Comment 4

[Markus Adrario [:Taraman]]

Attachment: inTabEditing.diff

It showed, that the differences are quite few.
So in a first step I changed the invokeEventDialog and setData functions to cope with any event editing dialog.

Then I let the testEventDialog run twice - once normally and once with in-Tab-Editing.

I also found a glitch in the Toolbarbutton-handling which I corrected.

try-run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&selectedJob=213685687&revision=27a98d073b92db3ec190a61ebc8e82a3ab50ae4b

Comment 5

[Markus Adrario [:Taraman]]

Comment on attachment 9027350 [details] [diff] [review]
inTabEditing.diff

I found that I have to think again about the code finding the Tab, since closing and opening an event tab causes its index number to rise.