129510 - Filter/Search: Text on dropdown menus is not left aligned

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[jglick]

2002030703 windows (and previous builds).

1. Open the Filter Rules or Search Messages dialog
2. Select "Priority" or "Status" in the first dropdown menu.

Notice the text in the 3rd dropdown menu is centered, not left aligned like the 
rest of the dropdown menus.

Comment 1

[jglick]

Attachment: Example of UI Nit :-)

Comment 2

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 3

[Cavin Song]

Reassigning.

Comment 4

[Cavin Song]

Reassigning.

Comment 5

[shliang]

Attachment: patch

the workaround for bug 78429 was somehow causing this, replacing with different
workaround which addresses the problem of the menuitems not having labels yet
when one is selected.

Comment 6

[(not reading, please use [e-mail] instead)]

with your fix, does bug #78429 re-appear?

if not, sr=sspitzer

once you check in, take bug #90739 as well. (remove work around for #78429 in
mailWidgets.xml)

Comment 7

[shliang]

no, this is just another way to do 78429 so that this bug doesn't happen. i 
think the real problem (the timing issue) might be related to bug 63370, so 
the workaround will need to stay until that is fixed.

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 115564 [details] [diff] [review]
patch

sr=sspitzer, if this doesn't regress #78429

Comment 9

[(not reading, please use [e-mail] instead)]

> once you check in, take bug #90739 as well. (remove work around for #78429 in
mailWidgets.xml)

sounds like we are just trading one workaround for a better one.

instead of marking #90739 fixed, we should morph it to cover the new work around
(which you and jag believe will not be necessary once #63370 is fixed)

before you check in, please add the "work around" comment back to the code:

// to work around bug #78429 and #129510
menulist.setAttribute("label", menulist.selectedItem.label);

Comment 10

[Cavin Song]

Comment on attachment 115564 [details] [diff] [review]
patch

r=cavin.

Comment 11

[shliang]

marking fixed.

Comment 12

[[e-mail]]

I'm seeing this warning alot since this patch went in:

Warning: reference to undefined property menulist.selectedItem.label
Source File: chrome://messenger/content/mailWidgets.xml#searchvalue.initialize()
Line: 5

Should it say menulist.selectedItem.getAttribute("label") ?

Comment 13

[shliang]

Attachment: fix js warnings

yes you're right, it should be .getAttribute rather than .label

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 116128 [details] [diff] [review]
fix js warnings

sr=sspitzer

Comment 15

[[e-mail]]

Supplementary patch checked in.

Comment 16

[esther]

Using trunk build 20030303 on winxp, macosx and linux this is fixed. verified