1297039 - Implement the preference for showing dropmarker or not in Downloads Panel

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Sean Lee [:seanlee][:weilonge]]

Since bug 1269962 is in landing process, the preference for showing dropmarker is strongly recommended.

Comment 1

[Sean Lee [:seanlee][:weilonge]]

Attachment: Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel.,

Review commit: https://reviewboard.mozilla.org/r/73264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73264/

Comment 2

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8783481 [details]
Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel.,

Hey Paolo, as we discussed in bug 1269962 comment 89, could you help to review the patch for a new preference for showing the dropmarker?

Thank you.

Comment 3

[:Paolo Amadini]

Comment on attachment 8783481 [details]
Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel.,

Take a look at <https://reviewboard.mozilla.org/r/67412/diff/1#0> for a simpler way to check the preference. You can check the new DownloadsCommon getter when the Downloads Panel is opened. Unfortunately we cannot keep the "panel." namespace, but a preference name like "showPanelDropmarker" could work.

The class approach looks good, just use ".downloadsHideDropmarker" as it puts the namespace first, and "hide" is more correct than "disable" for the CSS class.

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8783481 [details]
Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel.,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73264/diff/1-2/

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8783481 [details]
Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel.,

Hey Paolo, could you help to review the patch in the second round? Thank you.

Comment 6

[:Paolo Amadini]

Comment on attachment 8783481 [details]
Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel.,

https://reviewboard.mozilla.org/r/73264/#review71372

Looks good! r+ with the change below.

::: browser/app/profile/firefox.js:331
(Diff revision 2)
>  pref("browser.download.useDownloadDir", true);
>  pref("browser.download.folderList", 1);
>  pref("browser.download.manager.addToRecentDocs", true);
>  pref("browser.download.manager.resumeOnWakeDelay", 10000);
>  
> +pref("browser.download.showPanelDropmarker", true);

Since we will ship this feature only when all the development is complete, you can use this technique to limit this to Nightly and Developer Edition until we give the feature the green light:

https://dxr.mozilla.org/mozilla-central/rev/24763f58772d45279a935790f732d80851924b46/browser/app/profile/firefox.js#1214-1218

This way we are safe from shipping an incomplete feature accidentally, and it's clearer to others that the feature is not finished yet. We'll remove the safeguard when the rest is ready.

Comment 7

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8783481 [details]
Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel.,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73264/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4f6eb3d1fd8
Implement the preference for showing dropmarker or not in Downloads Panel., r=Paolo

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c4f6eb3d1fd8

Comment 10

[Adrian Florinescu [:aflorinescu]]

verified as fixed in Nightly 51.0a1 /20160913080508 .

Comment 11

[Andrei Vaida [:avaida]]

Updating flags based on Comment 10.