Closed Bug 129827 Opened 23 years ago Closed 23 years ago

[RR][AltSS]Regressions from 92868: Stylesheet switching broken; theme switching crashes [@ nsHTMLReflowState::ComputeMargin]; various pages crash/broken

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: caillon, Assigned: karnaze)

References

(
URL
)

Details

(4 keywords, Whiteboard: [Hixie-P1][Hixie-1.0])

Crash Data

This is a recent regression. Switching alternate stylesheets no longer works on the trunk. Using linux 2002030822, and a current CVS build. View > Use Stylesheet > FooSheet Actual results: Nothing changes immediately. Hovering over links will change the link styles to the new sheet.
Works in 2002030807, but not in 2002030822.
Keywords: regression
This is a serious regression.
Keywords: mozilla1.0, nsbeta1, useless-UI
Whiteboard: [Hixie-P1][Hixie-1.0]
The problem is that ENSURE_TRUE(parentContext) causes ReResolveStyleContext to fail for the root frame. This is a huge regression and prevents me from working on most of the bugs I was planning to look at for 1.0 (most of which deal with ReResolveStyleContext.)
Well, fixing what I mentioned in my previous comment fixes the most obvious of the problems, but there are still some significant problems remaining. Also, could you please not write lines longer than 80 characters?
I'm presuming that this regression is also what's causing theme switching to crash.
Summary: [AltSS] Stylesheet switching broken → [RR][AltSS] Stylesheet switching broken
OS: Linux → All
Should we back out the patch in question until these issues are resolved?
I suspect that bug 129850 and bug 129866 may be duplicates of this bug.
*** Bug 129850 has been marked as a duplicate of this bug. ***
Summary: [RR][AltSS] Stylesheet switching broken → [RR][AltSS] Stylesheet switching broken; theme switching crashes
*** Bug 129864 has been marked as a duplicate of this bug. ***
*** Bug 129866 has been marked as a duplicate of this bug. ***
Keywords: crash, topcrash
Summary: [RR][AltSS] Stylesheet switching broken; theme switching crashes → [RR][AltSS]Regressions from 92868: Stylesheet switching broken; theme switching crashes [@ nsHTMLReflowState::ComputeMargin]; various pages crash/broken
upgrading severity due to crashes
Severity: major → critical
The regressive checkin was backed out. Resolving this as FIXED (already reopened 92868).
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
*** Bug 129800 has been marked as a duplicate of this bug. ***
dbaron, it would be really helpful if you could give some examples of what you mean by "but there are still some significant problems remaining" in comment #5.
When I tried switching stylesheets on http://www.people.fas.harvard.edu/~dbaron/ , the background color changed as it should, but the text color for some of the text didn't.
David, Are you sure you are not just seeing bug 63863? Back on 2002/2/15, you said you were working on a patch and said that you should "...probably finish it sometime...". If you have the time, please do. It is a huge problem when using style switching! later, Jake
With the ENSURE_TRUE(parentContext) removed, switching style contexts on http://www.people.fas.harvard.edu/~dbaron/ looked ok to me, but I'm not as familar with that page, so I could be missing something.
Just a note...I noticed that during the 2 days this crash appeared before the checkin was backed out, the nsBox::GetBorder crash mentioned in bug 117088 also showed up again. Coincidence or related? Either way, this crash is gone according to the latest Talkback data. Marking verified.
Status: RESOLVED → VERIFIED
Yeah, this probably caused the nsBox::GetBorder, FlushMiscWidgetInfo, and nsCSSFrameConstructor::PaintBackgroundWithSC signatures in talkback as well.
Crash Signature: [@ nsHTMLReflowState::ComputeMargin]
You need to log in before you can comment on or make changes to this bug.