Closed Bug 1298436 Opened 5 years ago Closed 5 years ago
Narrate sometimes repeats the last paragraph over and over again
58 bytes, text/x-review-board-request
1.64 KB, patch
|Details | Diff | Splinter Review|
STR: 1. Go to https://blog.mozilla.org/futurereleases/2016/07/20/reducing-adobe-flash-usage-in-firefox/. 2. Switch to reader mode and start narration and let it read the whole article. 3. Narrate keeps reading the last paragraph over and over again. This seems to be a recent regression.
Last good revision: 03acce461254afbd7f9c7135a2608ac350d43bda First bad revision: d29c0af9420ddd8602a42d0289048224241e5f32 Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=03acce461254afbd7f9c7135a2608ac350d43bda&tochange=d29c0af9420ddd8602a42d0289048224241e5f32 Looks like the following bug has the changes which introduced the regression: https://bugzilla.mozilla.org/show_bug.cgi?id=1255261
Comment on attachment 8785627 [details] Bug 1298436 - Don't get caught in an endless loop when narrating last paragraph. https://reviewboard.mozilla.org/r/74768/#review72986
Attachment #8785627 - Flags: review?(jaws) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/830b1dcd8359 Don't get caught in an endless loop when narrating last paragraph. r=jaws
I've reproduced this issue also on Aurora 50.0a2 (2016-08-31) and Firefox 49 Beta 8 (buildID: 20160829102229).
Comment on attachment 8785627 [details] Bug 1298436 - Don't get caught in an endless loop when narrating last paragraph. Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: Last paragraph gets read repeatedly, forever. [Describe test coverage new/current, TreeHerder]: Added browser test for this. [Risks and why]: Low risk. [String/UUID change made/needed]: None
Verified fixed on Windows 7 x64 and Mac OSX 10.11 using latest Nightly 51.0a1 (buildID: 20160901030202).
Comment on attachment 8785627 [details] Bug 1298436 - Don't get caught in an endless loop when narrating last paragraph. Fix for a regression in a new feature, verified. Let's uplift this for the RC build.
I had to back this out for bc4 bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=1581768&repo=mozilla-beta https://hg.mozilla.org/releases/mozilla-beta/rev/f21c8cd0a959
This could still make the RC2 build which we are planning. Eitan do you think you can try fixing and landing again?
Liz, I have a pending patch in bug 1299653. This patch introduces a test that seems to exacerbate a layout bug. The actual fix is not an issue. Maybe we should land this without the test in 49?
Yes, sounds good, thank you Eitan!
This version does not have the breaking test. MozReview-Commit-ID: 7OZctto5QBF
And since we're post-merge: https://hg.mozilla.org/releases/mozilla-release/rev/73ff6c711423
You need to log in before you can comment on or make changes to this bug.