Closed
Bug 1298687
Opened 8 years ago
Closed 8 years ago
URL bar search suggestions notification should use --panel-separator-color instead of hsla(210, 4%, 10%, 0.14) for the bottom border
Categories
(Firefox :: Theme, defect, P4)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: dao, Assigned: Towkir, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(1 file)
|
802 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1296945 +++
https://dxr.mozilla.org/mozilla-central/rev/1a5b53a831e5a6c20de1b081c774feb3ff76756c/browser/themes/shared/urlbarSearchSuggestionsNotification.inc.css#2
hsla(210, 4%, 10%, 0.14) doesn't work well with dark and high-contrast themes. We should use var(--panel-separator-color) instead.
|
Assignee | |
Comment 1•8 years ago
|
||
Hello dao,
See if this is what you wanted.
Thanks
|
Reporter | |
Comment 2•8 years ago
|
||
Comment on attachment 8785718 [details] [diff] [review]
border_color.patch
Looks good!
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8785718 -
Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d26091707a7b
URL bar search suggestions notification's bottom border color updated; r=dao
|
|
Assignee | |
Comment 4•8 years ago
|
||
Looks like it is pushed, should the bug be marked as fixed ? or it will be done semi-automatically ?
Thanks
Flags: needinfo?(dao+bmo)
|
|
Reporter | |
Comment 5•8 years ago
|
||
It will be marked fixed once the patch has been merged from mozilla-inbound to mozilla-central.
Flags: needinfo?(dao+bmo)
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in
before you can comment on or make changes to this bug.
Description
•