URL bar search suggestions notification should use --panel-separator-color instead of hsla(210, 4%, 10%, 0.14) for the bottom border

RESOLVED FIXED in Firefox 51

Status

()

Firefox
Theme
P4
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dao, Assigned: Towkir, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
+++ This bug was initially created as a clone of Bug #1296945 +++

https://dxr.mozilla.org/mozilla-central/rev/1a5b53a831e5a6c20de1b081c774feb3ff76756c/browser/themes/shared/urlbarSearchSuggestionsNotification.inc.css#2

hsla(210, 4%, 10%, 0.14) doesn't work well with dark and high-contrast themes. We should use var(--panel-separator-color) instead.
(Assignee)

Comment 1

a year ago
Created attachment 8785718 [details] [diff] [review]
border_color.patch

Hello dao,
See if this is what you wanted.
Thanks
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Attachment #8785718 - Flags: review?(dao+bmo)
(Reporter)

Comment 2

a year ago
Comment on attachment 8785718 [details] [diff] [review]
border_color.patch

Looks good!
(Reporter)

Updated

a year ago
Attachment #8785718 - Flags: review?(dao+bmo) → review+

Comment 3

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d26091707a7b
URL bar search suggestions notification's bottom border color updated; r=dao
(Assignee)

Comment 4

a year ago
Looks like it is pushed, should the bug be marked as fixed ? or it will be done semi-automatically ?
Thanks
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 5

a year ago
It will be marked fixed once the patch has been merged from mozilla-inbound to mozilla-central.
Flags: needinfo?(dao+bmo)

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d26091707a7b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.