Open Bug 1301015 Opened 3 years ago Updated 3 months ago

[e10s-multi] Find a real fix for failing tests with multiple content processes

Categories

(Core :: DOM: Content Processes, defect, P3)

defect

Tracking

()

REOPENED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: gkrizsanits, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: leave-open, Whiteboard: [e10s-multi:+])

Attachments

(1 file)

For turning turning on 2 content processes on nightly we decided to force some test to run with single content process temporarily. These tests should be modified slightly to support multiple content processes. This is a meta bug to keep around a list of tests where additional work will be needed.
Blocks: e10s-multi
Depends on: 1294370
Depends on: 1294372
Depends on: 1294378
Depends on: 1294379
Depends on: 1294386
Depends on: 1285898
Whiteboard: [e10s-multi:?]
Whiteboard: [e10s-multi:?] → [e10s-multi:M2]
Whiteboard: [e10s-multi:M2] → [e10s-multi:?]
Whiteboard: [e10s-multi:?] → [e10s-multi:+]
As discussed with Gabor on IRC #e10s today, here's a commit that re-enables e10s-multi with some devtools tests.
Try seems happy about this: 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a400f2339f744a693a5aa7de919ac6179e31b2c6&group_state=expanded

Note that I didn't change anything to devtools, really just removed the process count pref, which seemed enough. So there must have been fixes in the meantime to made the situation better.
Attachment #8849129 - Flags: review?(gkrizsanits)
Comment on attachment 8849129 [details]
Bug 1301015 - Re-enable some devtools tests on e10s-multi;

https://reviewboard.mozilla.org/r/121958/#review123942

::: devtools/client/webconsole/test/browser_webconsole_split.js:10
(Diff revision 1)
>  function test() {
>    waitForExplicitFinish();
> -  SpecialPowers.pushPrefEnv({"set": [["dom.ipc.processCount", 1]]}, runTest);
> +  runTest();
>  }
>  
>  function runTest() {
>    // Test is slow on Linux EC2 instances - Bug 962931
>    requestLongerTimeout(2);

Actually here you can just rename |runTest| to |test| move the waitForExplicitFinish there and remove the current |test| function completly. It's no big deal if you don't though, and thanks again for this patch.
Attachment #8849129 - Flags: review?(gkrizsanits) → review+
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fcbf5460b633
Re-enable some devtools tests on e10s-multi; r=krizsa
https://hg.mozilla.org/mozilla-central/rev/fcbf5460b633
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
I'm planning to land a few more patches here for the other already working tests.
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Depends on: 1361992
Blocks: 1315042
Priority: -- → P2
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3

The leave-open keyword is there and there is no activity for 6 months.
:jimm, maybe it's time to close this bug?

Flags: needinfo?(jmathies)
Flags: needinfo?(jmathies)
You need to log in before you can comment on or make changes to this bug.