1301015 - [e10s-multi] Find a real fix for failing tests with multiple content processes

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P3)

Description

[Gabor Krizsanits (INACTIVE)]

For turning turning on 2 content processes on nightly we decided to force some test to run with single content process temporarily. These tests should be modified slightly to support multiple content processes. This is a meta bug to keep around a list of tests where additional work will be needed.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1301015 - Re-enable some devtools tests on e10s-multi;

Some devtools tests had been forced to run in e10s with just 1
content process in bug 1301340 and bug 1303113 because they were
failing.
Now there seems to have been enough e10s messaging fixes that these
tests work again. It seems safe to re-enable multi-content-processes
for them now.

Review commit: https://reviewboard.mozilla.org/r/121958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121958/

Comment 2

[Patrick Brosset <:pbro>]

As discussed with Gabor on IRC #e10s today, here's a commit that re-enables e10s-multi with some devtools tests.
Try seems happy about this: 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a400f2339f744a693a5aa7de919ac6179e31b2c6&group_state=expanded

Note that I didn't change anything to devtools, really just removed the process count pref, which seemed enough. So there must have been fixes in the meantime to made the situation better.

Comment 3

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8849129 [details]
Bug 1301015 - Re-enable some devtools tests on e10s-multi;

https://reviewboard.mozilla.org/r/121958/#review123942

::: devtools/client/webconsole/test/browser_webconsole_split.js:10
(Diff revision 1)
>  function test() {
>    waitForExplicitFinish();
> -  SpecialPowers.pushPrefEnv({"set": [["dom.ipc.processCount", 1]]}, runTest);
> +  runTest();
>  }
>  
>  function runTest() {
>    // Test is slow on Linux EC2 instances - Bug 962931
>    requestLongerTimeout(2);

Actually here you can just rename |runTest| to |test| move the waitForExplicitFinish there and remove the current |test| function completly. It's no big deal if you don't though, and thanks again for this patch.

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8849129 [details]
Bug 1301015 - Re-enable some devtools tests on e10s-multi;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/121958/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcbf5460b633
Re-enable some devtools tests on e10s-multi; r=krizsa

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fcbf5460b633

Comment 7

[Gabor Krizsanits (INACTIVE)]

I'm planning to land a few more patches here for the other already working tests.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jimm, maybe it's time to close this bug?

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jimm, maybe it's time to close this bug?