1301144 - Bugzilla API query now times out after the mass P3 priority change

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Ed Morley [:emorley]]

After bug 1298978, this query used by OrangeFactor fails after 5 mins:

$ time curl -IX GET "https://bugzilla.mozilla.org/bzapi/bug?keywords=intermittent-failure&i nclude_fields=id,summary,status,whiteboard&changed_after=2016-03-07"
curl: (52) Empty reply from server

real    5m11.941s
user    0m0.015s
sys     0m0.015s

I know it's an intensive query, but it still shouldn't take 5 minutes, should it?

Comment 1

[Dylan Hardison [:dylan] (he/him)]

it looks like the problem is the bzapi doesn't put a limit on those queries!

Probably related to this line: https://github.com/mozilla-bteam/bmo/blob/master/extensions/BzAPI/lib/Resources/Bug.pm#L188

Comment 2

[Ed Morley [:emorley]]

So it appears as though BzAPI is 2-6x slower than the REST API in some cases (bug 1301541), which would definitely help with this case. (Note: OrangeFactor is now using pagination plus also has partly moved away from BzAPI to the native REST API.)

I'm totally fine with there being limits as well (both overridable and enforced; eg a default of limit=500 plus a max of limit=XXX), people should expect to have to use pagination. 

My main desire is that queries in general should either:
(a) succeed and return a useful response
(b) time out after X seconds (where X isn't the 311 seconds of comment 0!)
(c) succeed, albeit return a capped number of results

...since to do 5 minutes of computation (as in comment 0) then throw it all away, is just a waste of everyone's time.

Comment 3

[Ed Morley [:emorley]]

After the recent fixes is working much better now (both via bzapi and native rest API):

$ time curl -IX GET "https://bugzilla.mozilla.org/bzapi/bug?keywords=intermittent-failure&i
nclude_fields=id,summary,status,whiteboard&changed_after=2016-03-07"
HTTP/1.1 200 OK
...

real    0m20.615s
user    0m0.030s
sys     0m0.015s

$ time curl -IX GET "https://bugzilla.mozilla.org/rest/bug?keywords=intermittent-failure&in
clude_fields=id,summary,status,whiteboard&changed_after=2016-03-07"
HTTP/1.1 200 OK
...

real    0m20.367s
user    0m0.046s
sys     0m0.031s