1301302 - Add l10n support for picker for <input type="time">

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P5)

Description

[Scott Wu [:scottwu]]

AM/PM string, warning message, and position of hour/minute/ampm should display correctly based on users' locale.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

This should come from Intl.getDisplayNames

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

As per the latest planning together with PM and the team, we're not going to have time picker UI.
Bug 1315911 had landed on pref-off the pop-up.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

:wesley_huang - I understand the repriotization, but why does it result in resolved/wontfix?

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Likely in the short term we're not going to spend efforts on the time picker UI.
But it's ok to leave it open (for future tracking purpose) so I'm making it reopened.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mstriemer, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Sam Johnson]

Attachment: Bug 1301302 - Add localization support for time input picker. r?#recomp-reviewers

Updates the time input picker to add time components in the correct order and with the correct display strings for the current locale.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/49afca7a6c57
https://hg.mozilla.org/integration/autoland/rev/954679c47b26
Add localization support for time input picker. r=jules

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/954679c47b26

Comment 9

[Thorin [:thorin]]

@pierov Does this require spoof_english handling? (set dom.forms.datetime.timepicker to true) - edit: test here https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/time#try_it

Comment 10

[Pier Angelo Vendrame]

As far as I can tell, this is already handled by using Services.locale.webExposedLocales to define locale: https://searchfox.org/firefox-main/rev/c280a3de79038960073359b0b4777c676320b76a/toolkit/modules/DateTimePickerPanel.sys.mjs#72.