1301784 - Pref-off Search Reset UI for 50 beta

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Javaun Moradi [:javaun]]

Let's talk about this one next week. We were deciding whether to pref this UI off in 50 before Beta, since we're going to run Shield Studies in 49 to see how users respond to it.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Already r+'ed by Panos as attachment 8780529 [details] [diff] [review] in bug 1294680.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8792819 [details] [diff] [review]
Patch

Similar to bug 1294680 comment 9. We still don't have results from the Shield study (that's planned for the 50 cycle if I understood correctly). This patch should land on mozilla-beta after the merge before beta1 is built.

Approval Request Comment
[Feature/regressing bug #]: bug 1203168
[User impact if declined]: the search reset feature would be exposed before we have data to prove that it actually has the desired effect.
[Describe test coverage new/current, TreeHerder]: N/A
[Risks and why]: low, just pref'ing the feature off for one cycle for now.
[String/UUID change made/needed]: none.

Comment 3

[Florian Quèze [:florian]]

[Tracking Requested - why for this release]: see comment 2.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8792819 [details] [diff] [review]
Patch

Ok, taking it on the behalf of Ritu to make sure it lands before we build beta 1.
Thanks

Comment 5

[Carsten Book [:Tomcat]]

landed on request from sylvestre in https://hg.mozilla.org/releases/mozilla-beta/rev/5c9cc179d047

Comment 6

[Andrei Vaida [:avaida]]

Flagging this for verification, just to make sure it's now default-off on Fx50.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

I believe this is now done.

Comment 8

[Petruta Horea [:phorea]]

Verified that the preference "browser.search.reset.enabled" is set to false by default on Firefox 50 beta 9 under Win 10 64-bit and Ubuntu 14.04 LTS 64-bit.