Closed
Bug 1328913
Opened 7 years ago
Closed 7 years ago
Pref-off Search Reset UI for beta and release
Categories
(Firefox :: Search, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 53
People
(Reporter: florian, Assigned: florian)
References
Details
(Whiteboard: [fxsearch])
Attachments
(2 files)
1.11 KB,
patch
|
past
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1.03 KB,
patch
|
past
:
review+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1301784 +++ I'm not sure which version of Firefox we are targeting to run our Shield study on search reset, but in bug 1301784 we landed a patch to pref off the feature in beta 1 for the 50 cycle, and for the 51 cycle it seems we all forgot about it... and it's currently enabled on the beta channel.
Assignee | ||
Comment 1•7 years ago
|
||
Let's do something with an ifdef this time, so that we can't forget it for the next cycle.
Attachment #8824100 -
Flags: review?(past)
Assignee | ||
Comment 2•7 years ago
|
||
RELEASE_BUILD was renamed to RELEASE_OR_BETA in the 52 cycle (bug 1304829) so beta51 needs a separate patch.
Attachment #8824101 -
Flags: review?(past)
Assignee | ||
Comment 3•7 years ago
|
||
[Tracking Requested - why for this release]: because we don't want to ship Search Reset unintentionally in 51.
tracking-firefox51:
--- → ?
Updated•7 years ago
|
Attachment #8824100 -
Flags: review?(past) → review+
Updated•7 years ago
|
Attachment #8824101 -
Flags: review?(past) → review+
Comment 4•7 years ago
|
||
I see another instance of RELEASE_BUILD in the tree: https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js#1300 Do you know if it was intentionally left?
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Panos Astithas [:past] from comment #4) > I see another instance of RELEASE_BUILD in the tree: > > https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all. > js#1300 > > Do you know if it was intentionally left? Seems very unlikely, I would guess bug 1309861 got bitrotted by bug 1304829.
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cc7fd77a6174d9e260ade51f5e244160d0d3633 Bug 1328913 - Pref-off Search Reset UI for beta and release, r=past.
Assignee | ||
Comment 7•7 years ago
|
||
Comment on attachment 8824100 [details] [diff] [review] Patch Approval Request Comment [Feature/Bug causing the regression]: The feature is bug 1203168, we don't want to ship it before doing a Shield study, which is currently being worked on. [User impact if declined]: release users would get the search reset prompt before we know for sure which impact it has. [Is this code covered by automated tests?]: Search Reset is well covered by tests, but this patch is just about preff'ing it off. [Has the fix been verified in Nightly?]: Not yet. [Needs manual test from QE? If yes, steps to reproduce]: Just verify in about:config that browser.search.reset.enabled is true on nightly and aurora, and false on beta/release. [Is the change risky?]: No. [Why is the change risky/not risky?]: Just preff'ing it off. [String changes made/needed]: None
Attachment #8824100 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 8824101 [details] [diff] [review] Patch for beta51 Approval Request Comment See comment 7.
Attachment #8824101 -
Flags: approval-mozilla-beta?
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2cc7fd77a617
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Comment 10•7 years ago
|
||
Comment on attachment 8824100 [details] [diff] [review] Patch Add the logic to pref this off for 52.
Attachment #8824100 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•7 years ago
|
||
Comment on attachment 8824101 [details] [diff] [review] Patch for beta51 Pref off the search UI work for 51, for now. This should make it into beta 13.
Attachment #8824101 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 12•7 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/fed81ec38bdf9a6ae80bdbedf5845d0fe84c1c86 https://hg.mozilla.org/releases/mozilla-beta/rev/6dc2ca24bd0bcb88992ae72e4fb8285ea8e24333
status-firefox51:
--- → fixed
status-firefox52:
--- → fixed
Comment 13•7 years ago
|
||
Flagging this for manual testing on 51b13 -- instructions available in Comment 7.
Flags: qe-verify+
Updated•7 years ago
|
Comment 14•7 years ago
|
||
Verified under Mac OS X 10.11.5 and Win 10 64-bit that the preference browser.search.reset.enabled is set to True on 53.0a1 and 52.0a2 2017-01-09 and to False on Firefox 51 beta 13.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•