1328913 - Pref-off Search Reset UI for beta and release

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Florian Quèze [:florian]]

+++ This bug was initially created as a clone of Bug #1301784 +++

I'm not sure which version of Firefox we are targeting to run our Shield study on search reset, but in bug 1301784 we landed a patch to pref off the feature in beta 1 for the 50 cycle, and for the 51 cycle it seems we all forgot about it... and it's currently enabled on the beta channel.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Let's do something with an ifdef this time, so that we can't forget it for the next cycle.

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch for beta51

RELEASE_BUILD was renamed to RELEASE_OR_BETA in the 52 cycle (bug 1304829) so beta51 needs a separate patch.

Comment 3

[Florian Quèze [:florian]]

[Tracking Requested - why for this release]: because we don't want to ship Search Reset unintentionally in 51.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

I see another instance of RELEASE_BUILD in the tree:

https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js#1300

Do you know if it was intentionally left?

Comment 5

[Florian Quèze [:florian]]

(In reply to Panos Astithas [:past] from comment #4)
> I see another instance of RELEASE_BUILD in the tree:
> 
> https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.
> js#1300
> 
> Do you know if it was intentionally left?

Seems very unlikely, I would guess bug 1309861 got bitrotted by bug 1304829.

Comment 6

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cc7fd77a6174d9e260ade51f5e244160d0d3633
Bug 1328913 - Pref-off Search Reset UI for beta and release, r=past.

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8824100 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/Bug causing the regression]: The feature is bug 1203168, we don't want to ship it before doing a Shield study, which is currently being worked on.
[User impact if declined]: release users would get the search reset prompt before we know for sure which impact it has.
[Is this code covered by automated tests?]: Search Reset is well covered by tests, but this patch is just about preff'ing it off.
[Has the fix been verified in Nightly?]: Not yet.
[Needs manual test from QE? If yes, steps to reproduce]: Just verify in about:config that browser.search.reset.enabled is true on nightly and aurora, and false on beta/release.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Just preff'ing it off.
[String changes made/needed]: None

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8824101 [details] [diff] [review]
Patch for beta51

Approval Request Comment
See comment 7.

Comment 9

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/2cc7fd77a617

Comment 10

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8824100 [details] [diff] [review]
Patch

Add the logic to pref this off for 52.

Comment 11

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8824101 [details] [diff] [review]
Patch for beta51

Pref off the search UI work for 51, for now. 
This should make it into beta 13.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fed81ec38bdf9a6ae80bdbedf5845d0fe84c1c86
https://hg.mozilla.org/releases/mozilla-beta/rev/6dc2ca24bd0bcb88992ae72e4fb8285ea8e24333

Comment 13

[Andrei Vaida [:avaida]]

Flagging this for manual testing on 51b13 -- instructions available in Comment 7.

Comment 14

[Petruta Horea [:phorea]]

Verified under Mac OS X 10.11.5 and Win 10 64-bit that the preference browser.search.reset.enabled is set to True on 53.0a1 and 52.0a2 2017-01-09 and to False on Firefox 51 beta 13.