Closed
Bug 1301945
Opened 8 years ago
Closed 8 years ago
In dark devedition theme the "i" identity icon (with any "dot" permissions) is almost invisible
Categories
(Firefox :: Theme, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox48 | --- | unaffected |
firefox49 | --- | unaffected |
firefox50 | --- | unaffected |
firefox51 | --- | verified |
firefox52 | --- | verified |
People
(Reporter: rick3162, Assigned: dao)
References
Details
(Keywords: regression, Whiteboard: [fxprivacy] fixed by bug 1303291)
Attachments
(2 files)
6.14 KB,
image/jpeg
|
Details | |
241.12 KB,
patch
|
gchang
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
STR (In Nightly 51 x64 in win10 x64 -- in DevEdition 50 x64 the issue doesn't occur) - open https://twitter.com. Click the Site identity button > '>' > More Information > in 'Permissions' tab change e.g. the 'Receive Notifications' to Allow. The identity icon is visible as expected (see the top of my screenshot) - Now switch to the 'Developer edition' theme (in about:addons|Appearance) and switch to the dark theme in the DevTools: the "i" identity icon (together with the "dot") is now almost invisible (see the bottom of my screenshot)
Summary: In dark theme the "i" identity icon (with any "dot" permissions state permissions) is almost invisible → In dark theme the "i" identity icon (with any "dot" permissions) is almost invisible
Updated•8 years ago
|
Status: UNCONFIRMED → NEW
status-firefox48:
--- → unaffected
status-firefox49:
--- → unaffected
status-firefox50:
--- → unaffected
status-firefox51:
--- → affected
Ever confirmed: true
Flags: qe-verify+
Whiteboard: [fxprivacy] [triage]
Comment 1•8 years ago
|
||
I wonder if this is a regression from bug 1263171.
Keywords: regression,
regressionwindow-wanted
Updated•8 years ago
|
Blocks: 1295502
Keywords: regressionwindow-wanted
Summary: In dark theme the "i" identity icon (with any "dot" permissions) is almost invisible → In dark devedition theme the "i" identity icon (with any "dot" permissions) is almost invisible
Comment 3•8 years ago
|
||
FxPrivacy is wondering if this is on your list, Dao. Thank you.
Flags: needinfo?(dao+bmo)
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Updated•8 years ago
|
Whiteboard: [fxprivacy] → [fxprivacy][triage]
Assignee | ||
Comment 4•8 years ago
|
||
Yeah, I can / should take this.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(dao+bmo)
Updated•8 years ago
|
Whiteboard: [fxprivacy][triage] → [fxprivacy]
Assignee | ||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fxprivacy] → [fxprivacy] fixed by bug 1303291
Target Milestone: --- → Firefox 52
Updated•8 years ago
|
Iteration: --- → 52.1 - Oct 3
Updated•8 years ago
|
QA Contact: paul.silaghi
Comment 6•8 years ago
|
||
Verified fixed FX 52.0a1 (2016-09-25) Win 7, Ubuntu 14.04, OS X 10.11, using the DevEdition theme enabler addon.
Status: RESOLVED → VERIFIED
Comment 7•8 years ago
|
||
Hi :dao, Since this bug is a regression and also affects 51, do you consider to uplift this for 51 if this patch is not too risky?
Flags: needinfo?(dao+bmo)
Assignee | ||
Comment 8•8 years ago
|
||
I think we can uplift bug 1303291 if we do it soon, but I'm still in the process of fixing a regression (bug 1304363).
Flags: needinfo?(dao+bmo)
Assignee | ||
Comment 9•8 years ago
|
||
This is the patch from bug 1303291 combined with that from bug 1304363. Approval Request Comment [Feature/regressing bug #]: bug 1295502, which was caused by bug 1022601 [User impact if declined]: see comment 0 [Describe test coverage new/current, TreeHerder]: there are tests for the icons displayed in the identity block (they only verify icon file names, not the visual result) [Risks and why]: Somewhat complex patch, but bug 1303291 has baked on mozilla-central since September 21 without a regression being reported except for bug 1304363. I think we should take it. Note that the patch file size is so large mostly because I've removed the unused identity-not-secure.svg (the entire file contents get listed in the patch) and because I'm changing conn-not-secure.svg (there's one huge <path> element that I indented further without changing the element itself). [String/UUID change made/needed]: none
Attachment #8796444 -
Flags: approval-mozilla-aurora?
Comment 10•8 years ago
|
||
Comment on attachment 8796444 [details] [diff] [review] patch for uplift Fix a UI regression and verified. The patch from bug 1303291 has baked on mozilla-central for a while. We can take it in 51 aurora and see what will happen.
Attachment #8796444 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 13•8 years ago
|
||
I confirm that the issue is fixed in Firefox 51 in win10, in normal windows, (I have the https://addons.mozilla.org/en-US/firefox/addon/devedition-theme-enabler/ installed) but in private windows the issue still occurs. Screenshots in private window (all with 1 'dot' permission) from FF51 stable with the addon installed: http://i.imgur.com/Ztisozt.jpg <-- (regular site) http://edition.cnn.com/ http://i.imgur.com/BXw00ZS.jpg <-- (site with SSL encryption) https://twitter.com/ http://i.imgur.com/efvOees.jpg <-- (Site with EV certificate) https://addons.mozilla.org/en-US/firefox/ In all these cases the "i" identity icon is almost invisible.
Comment 14•8 years ago
|
||
(In reply to Kostas from comment #13) > but in private windows the issue still occurs. should be fixed in 53 - bug 1309532
You need to log in
before you can comment on or make changes to this bug.
Description
•