1301945 - In dark devedition theme the "i" identity icon (with any "dot" permissions) is almost invisible

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Kostas]

Attachment: Combined screenshots.jpg

STR

(In Nightly 51 x64 in win10 x64 -- in DevEdition 50 x64 the issue doesn't occur)
- open https://twitter.com. 
Click the Site identity button > '>' > More Information > in 'Permissions' tab change  e.g. the 'Receive Notifications' to Allow.
The identity icon is visible as expected (see the top of my screenshot)
- Now switch to the 'Developer edition' theme (in about:addons|Appearance) and switch to the dark theme in the DevTools: 
the "i" identity icon (together with the "dot") is now almost invisible (see the bottom of my screenshot)

Comment 1

[:Gijs (he/him)]

I wonder if this is a regression from bug 1263171.

Comment 2

[Kostas]

Regression range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c1cf1e462ff9567386a33d7288bfc6c6a473f159&tochange=30f6fa5980fae2cc5a1f377cbd4736a330b4b35a

Comment 3

[Erin Lancaster [:elan]]

FxPrivacy is wondering if this is on your list, Dao. Thank you.

Comment 4

[Dão Gottwald [:dao]]

Yeah, I can / should take this.

Comment 6

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 52.0a1 (2016-09-25) Win 7, Ubuntu 14.04, OS X 10.11, using the DevEdition theme enabler addon.

Comment 7

[Gerry Chang [:gchang]]

Hi :dao,
Since this bug is a regression and also affects 51, do you consider to uplift this for 51 if this patch is not too risky?

Comment 8

[Dão Gottwald [:dao]]

I think we can uplift bug 1303291 if we do it soon, but I'm still in the process of fixing a regression (bug 1304363).

Comment 9

[Dão Gottwald [:dao]]

Attachment: patch for uplift

This is the patch from bug 1303291 combined with that from bug 1304363.

Approval Request Comment
[Feature/regressing bug #]: bug 1295502, which was caused by bug 1022601

[User impact if declined]: see comment 0

[Describe test coverage new/current, TreeHerder]: there are tests for the icons displayed in the identity block (they only verify icon file names, not the visual result)

[Risks and why]: Somewhat complex patch, but bug 1303291 has baked on mozilla-central since September 21 without a regression being reported except for bug 1304363. I think we should take it.

Note that the patch file size is so large mostly because I've removed the unused identity-not-secure.svg (the entire file contents get listed in the patch) and because I'm changing conn-not-secure.svg (there's one huge <path> element that I indented further without changing the element itself).

[String/UUID change made/needed]: none

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8796444 [details] [diff] [review]
patch for uplift

Fix a UI regression and verified. The patch from bug 1303291 has baked on mozilla-central for a while. We can take it in 51 aurora and see what will happen.

Comment 11

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/805d5fc3d66c

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 51.0a2 (2016-10-18) Win 7

Comment 13

[Kostas]

I confirm that the issue is fixed in Firefox 51 in win10, in normal windows, (I have the https://addons.mozilla.org/en-US/firefox/addon/devedition-theme-enabler/ installed)
but in private windows the issue still occurs.

Screenshots in private window (all with 1 'dot' permission) from FF51 stable with the addon installed:
http://i.imgur.com/Ztisozt.jpg <-- (regular site) http://edition.cnn.com/ 
http://i.imgur.com/BXw00ZS.jpg <-- (site with SSL encryption) https://twitter.com/
http://i.imgur.com/efvOees.jpg <-- (Site with EV certificate) https://addons.mozilla.org/en-US/firefox/

In all these cases the "i" identity icon is almost invisible.

Comment 14

[Paul Silaghi, QA [:pauly]]

(In reply to Kostas from comment #13)
> but in private windows the issue still occurs.
should be fixed in 53 - bug 1309532