1330243 - Update stagefright_MPEG4Metadata gtest for rust mp4 parser

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Alfredo Yang (:alfredo)]

test_case_1181213.mp4 is encrypted. Both rust parser and MP4Box can parse the pssh box but stagefright can't.
It should be stagefright bug.

We need to change the crypt to true in TestFileData table once rust parser is enabled.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

(In reply to Alfredo Yang (:alfredo) from comment #0)
> test_case_1181213.mp4 is encrypted. Both rust parser and MP4Box can parse
> the pssh box but stagefright can't.
> It should be stagefright bug.

I think (guessing without actually debugging) that what's happening in stagefright is that once the issue in that test case is found, no further parsing happens, so it doesn't parse the pssh (or maybe doesn't save it, if it was parsed beforehand.)
I'm guessing the rust parser may be able to recover, or has successfully saved the pssh.

Also, since that file doesn't contain any valid tracks, it shouldn't matter if the pssh can't be read!

So in the end, I'm not sure it's an actual bug that we'd want to fix.


> We need to change the crypt to true in TestFileData table once rust parser
> is enabled.

Or maybe it could be updated so that the presence of encryption is not checked in this case?


Please let me know if you'd like me to have a deeper look at what's actually happening.

Comment 2

[Alfredo Yang (:alfredo)]

(In reply to Gerald Squelart [:gerald] from comment #1)
> (In reply to Alfredo Yang (:alfredo) from comment #0)
> 
> Or maybe it could be updated so that the presence of encryption is not
> checked in this case?

Yes, that's my current plan. :-)

> 
> 
> Please let me know if you'd like me to have a deeper look at what's actually
> happening.

Comment 3

[Alfredo Yang (:alfredo)]

As comment 1, the test table needs to be updated when rust parser is enabled.

Comment 4

[Alfredo Yang (:alfredo)]

Attachment: Bug 1330243 - add preference to enable rust mp4 parser.

Review commit: https://reviewboard.mozilla.org/r/123666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123666/

Comment 5

[Alfredo Yang (:alfredo)]

Attachment: Bug 1330243 - update gtest for mp4 rust parser.

Review commit: https://reviewboard.mozilla.org/r/123668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123668/

Comment 6

[Matthew Gregan [:kinetik]]

Comment on attachment 8851361 [details]
Bug 1330243 - update gtest for mp4 rust parser.

https://reviewboard.mozilla.org/r/123668/#review126176

Comment 7

[Matthew Gregan [:kinetik]]

Comment on attachment 8851360 [details]
Bug 1330243 - add preference to enable rust mp4 parser.

https://reviewboard.mozilla.org/r/123666/#review126178

Comment 8

[Alfredo Yang (:alfredo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9d9a1ecf79c45f5324fb9dd9d617ed820d7e63b

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d539d11ebc9
add preference to enable rust mp4 parser. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/7ac8812719a1
update gtest for mp4 rust parser. r=kinetik

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d539d11ebc9
https://hg.mozilla.org/mozilla-central/rev/7ac8812719a1