Closed Bug 1302405 Opened 4 years ago Closed 4 years ago

Remove special styling for non-default Windows themes from panelUI.css

Categories

(Firefox :: Theme, defect, P3)

Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
With bug 1302355 fixed, I think we've now replaced all hardcoded colors in the menu panel with platform colors or at least with hardcoded colors that work well enough on dark backgrounds.

This means we can get rid of the special styling for non-default Windows theme in panelUI.css, making Windows more consistent with OS X and Linux (where we need to support dark themes too) and eliminating a separate code path that is already badly maintained, e.g. the hover styling for the panel footer buttons (Sync, Customize, Help, Quit) looks somewhat broken or at least weirdly inconsistent.
Attachment #8790683 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8790683 [details] [diff] [review]
patch

Review of attachment 8790683 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks for cleaning this up.
Attachment #8790683 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/361caf6a2399
Remove special styling for non-default Windows themes from panelUI.css. r=gijs
https://hg.mozilla.org/mozilla-central/rev/361caf6a2399
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.