Remove special styling for non-default Windows themes from panelUI.css

RESOLVED FIXED in Firefox 51

Status

()

Firefox
Theme
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 51
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Created attachment 8790683 [details] [diff] [review]
patch

With bug 1302355 fixed, I think we've now replaced all hardcoded colors in the menu panel with platform colors or at least with hardcoded colors that work well enough on dark backgrounds.

This means we can get rid of the special styling for non-default Windows theme in panelUI.css, making Windows more consistent with OS X and Linux (where we need to support dark themes too) and eliminating a separate code path that is already badly maintained, e.g. the hover styling for the panel footer buttons (Sync, Customize, Help, Quit) looks somewhat broken or at least weirdly inconsistent.
Attachment #8790683 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8790683 [details] [diff] [review]
patch

Review of attachment 8790683 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks for cleaning this up.
Attachment #8790683 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 2

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/361caf6a2399
Remove special styling for non-default Windows themes from panelUI.css. r=gijs

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/361caf6a2399
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.