Implement shared header for two ProxyAccessible classes

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: michael.li11702, Assigned: michael.li11702)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
MozReview-Commit-ID: XDVNySUTx
Assignee

Comment 1

3 years ago
Attachment #8791615 - Flags: review?(tbsaunde+mozbugs)
Assignee

Updated

3 years ago
Assignee: nobody → mili
Assignee

Updated

3 years ago
Blocks: 1288839
Assignee

Updated

3 years ago
Blocks: 1301148
Assignee

Updated

3 years ago
Blocks: 1303133
Assignee

Updated

3 years ago
Blocks: 1303447
Comment on attachment 8791615 [details] [diff] [review]
Implement shared header for two ProxyAccessible classes

>+
>+// XXX checking mRole alone may not result in same behavior as Accessibles
>+// due to ARIA roles. See bug 1210477.
>+inline bool IsTable() const
>+{
>+  return mRole == roles::TABLE || mRole == roles::MATHML_TABLE;
>+}
>+inline bool IsTableRow() const
>+{
>+  return (mRole == roles::ROW ||
>+      mRole == roles::MATHML_TABLE_ROW ||
>+      mRole == roles::MATHML_LABELED_ROW);
>+}
>+inline bool IsTableCell() const
>+{
>+  return (mRole == roles::CELL ||
>+      mRole == roles::COLUMNHEADER ||
>+      mRole == roles::ROWHEADER ||
>+      mRole == roles::GRID_CELL ||
>+      mRole == roles::MATHML_CELL);
>+}

I think these might as well go in ProxyAccessibleBase.h but this is fine for now I guess.
Attachment #8791615 - Flags: review?(tbsaunde+mozbugs) → review+

Comment 3

3 years ago
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3724de5184
implement shared header for two ProxyAccessible classes. r=tbsaunde

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1b3724de5184
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.