Closed Bug 1303040 Opened 5 years ago Closed 5 years ago

Implement shared header for two ProxyAccessible classes

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: michael.li11702, Assigned: michael.li11702)

References

Details

Attachments

(1 file)

MozReview-Commit-ID: XDVNySUTx
Attachment #8791615 - Flags: review?(tbsaunde+mozbugs)
Assignee: nobody → mili
Blocks: 1288839
Blocks: 1301148
Blocks: 1303133
Blocks: 1303447
Comment on attachment 8791615 [details] [diff] [review]
Implement shared header for two ProxyAccessible classes

>+
>+// XXX checking mRole alone may not result in same behavior as Accessibles
>+// due to ARIA roles. See bug 1210477.
>+inline bool IsTable() const
>+{
>+  return mRole == roles::TABLE || mRole == roles::MATHML_TABLE;
>+}
>+inline bool IsTableRow() const
>+{
>+  return (mRole == roles::ROW ||
>+      mRole == roles::MATHML_TABLE_ROW ||
>+      mRole == roles::MATHML_LABELED_ROW);
>+}
>+inline bool IsTableCell() const
>+{
>+  return (mRole == roles::CELL ||
>+      mRole == roles::COLUMNHEADER ||
>+      mRole == roles::ROWHEADER ||
>+      mRole == roles::GRID_CELL ||
>+      mRole == roles::MATHML_CELL);
>+}

I think these might as well go in ProxyAccessibleBase.h but this is fine for now I guess.
Attachment #8791615 - Flags: review?(tbsaunde+mozbugs) → review+
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3724de5184
implement shared header for two ProxyAccessible classes. r=tbsaunde
https://hg.mozilla.org/mozilla-central/rev/1b3724de5184
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.