1303040 - Implement shared header for two ProxyAccessible classes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Michael Li]

MozReview-Commit-ID: XDVNySUTx

Comment 1

[Michael Li]

Attachment: Implement shared header for two ProxyAccessible classes

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8791615 [details] [diff] [review]
Implement shared header for two ProxyAccessible classes

>+
>+// XXX checking mRole alone may not result in same behavior as Accessibles
>+// due to ARIA roles. See bug 1210477.
>+inline bool IsTable() const
>+{
>+  return mRole == roles::TABLE || mRole == roles::MATHML_TABLE;
>+}
>+inline bool IsTableRow() const
>+{
>+  return (mRole == roles::ROW ||
>+      mRole == roles::MATHML_TABLE_ROW ||
>+      mRole == roles::MATHML_LABELED_ROW);
>+}
>+inline bool IsTableCell() const
>+{
>+  return (mRole == roles::CELL ||
>+      mRole == roles::COLUMNHEADER ||
>+      mRole == roles::ROWHEADER ||
>+      mRole == roles::GRID_CELL ||
>+      mRole == roles::MATHML_CELL);
>+}

I think these might as well go in ProxyAccessibleBase.h but this is fine for now I guess.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3724de5184
implement shared header for two ProxyAccessible classes. r=tbsaunde

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1b3724de5184