Implement ia2AccessibleValue methods in ProxyAccessible for Windows

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: michael.li11702, Assigned: michael.li11702)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
MozReview-Commit-ID: 5nM9Q9Adtir
(Assignee)

Comment 1

3 years ago
Attachment #8791750 - Flags: review?(tbsaunde+mozbugs)
(Assignee)

Updated

3 years ago
Assignee: nobody → mili
(Assignee)

Updated

3 years ago
Blocks: 1288839
Comment on attachment 8791750 [details] [diff] [review]
Implement ia2AccessibleValue methods in ProxyAccessible for Windows

This needs to be rebased on top of the shared header and QueryInterface wrapper patches, but it seems fine otherwise.
Attachment #8791750 - Flags: review?(tbsaunde+mozbugs)
oh, and you need to check the varient is actually holding a double before getting it out of the varient.
(Assignee)

Updated

3 years ago
Depends on: 1303040
(Assignee)

Comment 4

3 years ago
Attachment #8792125 - Flags: review?(tbsaunde+mozbugs)
(Assignee)

Updated

3 years ago
Attachment #8791750 - Attachment is obsolete: true
Attachment #8792125 - Attachment is obsolete: true
Attachment #8792125 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8801862 [details] [diff] [review]
implement the value related methods in the windows ProxyAccessible r?aklotz

Review of attachment 8801862 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/ipc/win/ProxyAccessible.cpp
@@ +335,5 @@
> +  VariantInit(&currentValue);
> +  currentValue.vt = VT_R8;
> +  currentValue.dblVal = aValue;
> +  HRESULT hr = acc->setCurrentValue(currentValue);
> +  return !FAILED(hr);

s/!FAILED/SUCCEEDED/
Attachment #8801862 - Flags: review?(aklotz) → review+

Comment 7

3 years ago
Pushed by tsaunders@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81a257aa9c4e
Implement ia2AccessibleValue methods in ProxyAccessible for Windows. r=aklotz

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/81a257aa9c4e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.