1303133 - Implement ia2AccessibleValue methods in ProxyAccessible for Windows

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Michael Li]

MozReview-Commit-ID: 5nM9Q9Adtir

Comment 1

[Michael Li]

Attachment: Implement ia2AccessibleValue methods in ProxyAccessible for Windows

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8791750 [details] [diff] [review]
Implement ia2AccessibleValue methods in ProxyAccessible for Windows

This needs to be rebased on top of the shared header and QueryInterface wrapper patches, but it seems fine otherwise.

Comment 3

[Trevor Saunders (:tbsaunde)]

oh, and you need to check the varient is actually holding a double before getting it out of the varient.

Comment 4

[Michael Li]

Attachment: Implement ia2AccessibleValue methods in ProxyAccessible for Windows

Comment 5

[Trevor Saunders (:tbsaunde)]

Attachment: implement the value related methods in the windows ProxyAccessible r?aklotz

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8801862 [details] [diff] [review]
implement the value related methods in the windows ProxyAccessible r?aklotz

Review of attachment 8801862 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/ipc/win/ProxyAccessible.cpp
@@ +335,5 @@
> +  VariantInit(&currentValue);
> +  currentValue.vt = VT_R8;
> +  currentValue.dblVal = aValue;
> +  HRESULT hr = acc->setCurrentValue(currentValue);
> +  return !FAILED(hr);

s/!FAILED/SUCCEEDED/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81a257aa9c4e
Implement ia2AccessibleValue methods in ProxyAccessible for Windows. r=aklotz

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/81a257aa9c4e