1303702 - bug history table 'when' column shows 00:00 only using sqlite

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[andrea.orsini]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160803000359

Steps to reproduce:

Start bugzilla using sqlite as database. File a bug and modify its status some times just to put some entries in the history table. Go to the history page of the bug (show_activity.cgi).


Actual results:

All the time entries in the 'when' column have the right date but the time is fixed to 00:00.


Expected results:

The right modify time is expected to be retrieved from the database and printed in the field instead of 00:00.

Comment 1

[andrea.orsini]

Attachment: patch, v1

%s means 'seconds from epoch' for sqlite. When the developer writes %s in the other modules he means the %s in the mysql meaning which is [0-59] and it's represented with %S in sqlite queries.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8792464 [details] [diff] [review]
patch, v1

Nice catch! Thanks for reporting and fixing this.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

To github.com:bugzilla/bugzilla.git
   3577aee..26a6446  4.4 -> 4.4

To github.com:bugzilla/bugzilla.git
   9c8ceda..fe2251f  5.0 -> 5.0

To github.com:bugzilla/bugzilla.git
   c67b3b3..d10a58f  master -> master