bug history table 'when' column shows 00:00 only using sqlite

RESOLVED FIXED in Bugzilla 4.4

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: andrea.orsini, Assigned: andrea.orsini)

Tracking

Bugzilla 4.4
Bug Flags:
approval +
approval5.0 +
approval4.4 +
relnote ?

Details

Attachments

(1 attachment)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160803000359

Steps to reproduce:

Start bugzilla using sqlite as database. File a bug and modify its status some times just to put some entries in the history table. Go to the history page of the bug (show_activity.cgi).


Actual results:

All the time entries in the 'when' column have the right date but the time is fixed to 00:00.


Expected results:

The right modify time is expected to be retrieved from the database and printed in the field instead of 00:00.
Posted patch patch, v1Splinter Review
%s means 'seconds from epoch' for sqlite. When the developer writes %s in the other modules he means the %s in the mysql meaning which is [0-59] and it's represented with %S in sqlite queries.
Attachment #8792464 - Flags: review?(dylan)
See Also: → 938161
Assignee: database → andrea.orsini
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 4.4
Comment on attachment 8792464 [details] [diff] [review]
patch, v1

Nice catch! Thanks for reporting and fixing this.
Attachment #8792464 - Flags: review?(dylan) → review+
Flags: approval5.0+
Flags: approval4.4+
Flags: approval+
To github.com:bugzilla/bugzilla.git
   3577aee..26a6446  4.4 -> 4.4

To github.com:bugzilla/bugzilla.git
   9c8ceda..fe2251f  5.0 -> 5.0

To github.com:bugzilla/bugzilla.git
   c67b3b3..d10a58f  master -> master
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: relnote?
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.