1304919 - Update Firefox to NSS trunk (3.28)

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Eric Rescorla (:ekr)]

Try push for prototype patch.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd4ee983895e

Comment 1

[Eric Rescorla (:ekr)]

Attachment: - Update Firefox to NSS trunk (fix PSM)

MozReview-Commit-ID: CKlvRQ5CsrT

Comment 2

[Eric Rescorla (:ekr)]

Attachment: - Update Firefox to NSS trunk (fix PSM)

MozReview-Commit-ID: A2SInDEZnnF

Comment 3

[Eric Rescorla (:ekr)]

Attachment: Update NSS

Review commit: https://reviewboard.mozilla.org/r/80584/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80584/

Comment 4

[Eric Rescorla (:ekr)]

Attachment: TLS 1.3 draft-16 adaptation

Review commit: https://reviewboard.mozilla.org/r/80586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80586/

Comment 5

[Eric Rescorla (:ekr)]

Attachment: Bug 1304919 -- Update Firefox to NSS trunk (fix PSM)

Review commit: https://reviewboard.mozilla.org/r/80588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80588/

Comment 6

[Martin Thomson [:mt:]]

Comment on attachment 8794020 [details]
Update NSS

https://reviewboard.mozilla.org/r/80584/#review79288

Fix the commit message and add eccutil.h (hg add).

Comment 7

[Martin Thomson [:mt:]]

Comment on attachment 8794022 [details]
Bug 1304919 -- Update Firefox to NSS trunk (fix PSM)

https://reviewboard.mozilla.org/r/80588/#review79292

::: security/manager/ssl/nsNSSCallbacks.cpp
(Diff revision 1)
> -              MOZ_LOG(gPIPNSSLog, LogLevel::Error, ("Auth Type=%d\n",
> -                                                    channelInfo.authType));

Squash this.

Comment 8

[Martin Thomson [:mt:]]

Comment on attachment 8794021 [details]
TLS 1.3 draft-16 adaptation

https://reviewboard.mozilla.org/r/80586/#review79294

Fix the commit message and squash the next.

Comment 10

[Martin Thomson [:mt:]]

Attachment: Bug 1304919 - Update Firefox to NSS trunk,

Review commit: https://reviewboard.mozilla.org/r/80630/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80630/

Comment 11

[Martin Thomson [:mt:]]

Attachment: Bug 1304919 - PSM changes to support TLS 1.3 key exchange,

Review commit: https://reviewboard.mozilla.org/r/80632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80632/

Comment 12

[Martin Thomson [:mt:]]

Attachment: Bug 1304919 - Update TLS server tests to expect TLS 1.3 cipher suite,

Review commit: https://reviewboard.mozilla.org/r/80634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80634/

Comment 13

[Martin Thomson [:mt:]]

Attachment: Bug 1304919 - Update WebRTC to latest NSS,

Review commit: https://reviewboard.mozilla.org/r/80636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80636/

Comment 14

[Martin Thomson [:mt:]]

Comment on attachment 8794049 [details]
Bug 1304919 - Update Firefox to NSS trunk,

https://reviewboard.mozilla.org/r/80630/#review79324

Comment 15

[Martin Thomson [:mt:]]

Comment on attachment 8794050 [details]
Bug 1304919 - PSM changes to support TLS 1.3 key exchange,

https://reviewboard.mozilla.org/r/80632/#review79326

Fix that extra line.

::: security/manager/ssl/nsNSSCallbacks.cpp:1178
(Diff revision 1)
> +              MOZ_LOG(gPIPNSSLog, LogLevel::Error, ("Auth Type=%d\n",
> +                                                    channelInfo.authType));

Gah

Comment 16

[Martin Thomson [:mt:]]

Comment on attachment 8794050 [details]
Bug 1304919 - PSM changes to support TLS 1.3 key exchange,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80632/diff/1-2/

Comment 17

[Martin Thomson [:mt:]]

Comment on attachment 8794051 [details]
Bug 1304919 - Update TLS server tests to expect TLS 1.3 cipher suite,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80634/diff/1-2/

Comment 18

[Martin Thomson [:mt:]]

Comment on attachment 8794052 [details]
Bug 1304919 - Update WebRTC to latest NSS,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80636/diff/1-2/

Comment 19

[Eric Rescorla (:ekr)]

Comment on attachment 8794051 [details]
Bug 1304919 - Update TLS server tests to expect TLS 1.3 cipher suite,

https://reviewboard.mozilla.org/r/80634/#review79388

LGTM

Comment 20

[Eric Rescorla (:ekr)]

Comment on attachment 8794052 [details]
Bug 1304919 - Update WebRTC to latest NSS,

https://reviewboard.mozilla.org/r/80636/#review79390

::: media/mtransport/transportlayerdtls.cpp:461
(Diff revision 2)
> +  ssl_grp_ffdhe_2048,
> +  ssl_grp_ffdhe_3072
> +};

Is there any actual point in enabling the FFDHE groups? IIRC the only counterparties who support FFDHE don't implement 7919

::: media/mtransport/transportlayerdtls.cpp:599
(Diff revision 2)
> +  rv = SSL_NamedGroupConfig(ssl_fd, NamedGroupPreferences,
> +                            mozilla::ArrayLength(NamedGroupPreferences));
> +  if (rv != SECSuccess) {
> +    MOZ_MTLOG(ML_ERROR, "Couldn't disable ECDHE key reuse");
> +    return false;
> +  }
> +

Need to fix cut-and-pasted error message.

::: media/mtransport/transportlayerdtls.cpp:709
(Diff revision 2)
>    TLS_RSA_WITH_AES_128_GCM_SHA256,
> +  TLS_RSA_WITH_AES_256_GCM_SHA384,
>    TLS_RSA_WITH_AES_128_CBC_SHA,
>    TLS_RSA_WITH_AES_128_CBC_SHA256,

This feels like it reveals a weakness in this design :)

Comment 21

[Martin Thomson [:mt:]]

Comment on attachment 8794052 [details]
Bug 1304919 - Update WebRTC to latest NSS,

https://reviewboard.mozilla.org/r/80636/#review79390

> Is there any actual point in enabling the FFDHE groups? IIRC the only counterparties who support FFDHE don't implement 7919

Yes, because if we don't enable them, then - as a server - we won't do DHE suites.

> This feels like it reveals a weakness in this design :)

Yeah, but we the alternative is much more complicated.  This works well enough.  (And negotiating that cipher suite isn't the end of the world.)

Comment 22

[Martin Thomson [:mt:]]

Comment on attachment 8794051 [details]
Bug 1304919 - Update TLS server tests to expect TLS 1.3 cipher suite,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80634/diff/2-3/

Comment 23

[Martin Thomson [:mt:]]

Comment on attachment 8794052 [details]
Bug 1304919 - Update WebRTC to latest NSS,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80636/diff/2-3/

Comment 25

[Eric Rescorla (:ekr)]

Comment on attachment 8794052 [details]
Bug 1304919 - Update WebRTC to latest NSS,

https://reviewboard.mozilla.org/r/80636/#review79572

LGTM

Comment 26

[Eric Rescorla (:ekr)]

Comment on attachment 8794051 [details]
Bug 1304919 - Update TLS server tests to expect TLS 1.3 cipher suite,

https://reviewboard.mozilla.org/r/80634/#review79570

This continues to LGTM

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7e412fddbbc
Update Firefox to NSS trunk, r=mt
https://hg.mozilla.org/integration/mozilla-inbound/rev/b54d608edfa8
PSM changes to support TLS 1.3 key exchange, r=mt
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb62ee48735e
Update TLS server tests to expect TLS 1.3 cipher suite, r=ekr
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1aace586e14
Update WebRTC to latest NSS, r=ekr

Comment 28

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for mass test failures on OS X 10.10 opt in tests which mock (encrypted?) connections:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c004ac338be00d7ceb5c38cc46f1219074d2ac4
https://hg.mozilla.org/integration/mozilla-inbound/rev/4658256016c39e6ed4c2fc5eef73b0a68fc3492e
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddd64e2cf55f055ddb031ce84d620b6211addaa1
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c0e181dba102950b3034cf8a449c4070178479

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f1aace586e14a276cc43dd00111d5c9d04580ea0
Screenshot from a failing test: http://mozilla-releng-blobs.s3.amazonaws.com/blobs/mozilla-inbound/sha512/da6cdf295d609284f274c5eb5f4de60261be79d2ce7237b5751bbd32b573f40530dddc869a8973dde617cdcd87aaff4dbcbb4ce17a3a2a8d0e2fa0aa7f15b3f2

Comment 29

[Martin Thomson [:mt:]]

I think that I understand what is going on, strange that it's only the OSX 10.10 build that burned though.  I updated NSS twice in developing the patch.  The script that updates NSS toggles a useless change in security/nss/coreconf/coreconf.dep, which apparently the build system uses as a trigger to clobber just NSS.  This doesn't cause any problems on try, but apparently we don't do clobber builds on inbound, so it burned up.

More justification to work on bug 1237872.

I've another try build, which I will check in on and land if it looks moderately good.  I've picked up a few more NSS commits in the process, but none that should affect Firefox:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11b6add1747f

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f78960aea76
Update NSS to trunk, r=ekr
https://hg.mozilla.org/integration/mozilla-inbound/rev/96991c815ab8
PSM changes to support TLS 1.3 key exchange, r=mt
https://hg.mozilla.org/integration/mozilla-inbound/rev/a32d729a8c6b
Update TLS server tests to expect TLS 1.3 cipher suite, r=ekr
https://hg.mozilla.org/integration/mozilla-inbound/rev/494e0af296f6
Update WebRTC to latest NSS, r=ekr

Comment 31

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f78960aea76
https://hg.mozilla.org/mozilla-central/rev/96991c815ab8
https://hg.mozilla.org/mozilla-central/rev/a32d729a8c6b
https://hg.mozilla.org/mozilla-central/rev/494e0af296f6

Comment 32

[Eric Rescorla (:ekr)]

Comment on attachment 8794050 [details]
Bug 1304919 - PSM changes to support TLS 1.3 key exchange,

This is one of three supporting patches for the NSS 3.28 uplift to Beta.
See bug 1305970

Comment 33

[Eric Rescorla (:ekr)]

Comment on attachment 8794051 [details]
Bug 1304919 - Update TLS server tests to expect TLS 1.3 cipher suite,

This is one of three supporting patches for the 3.28 uplift to Beta. See approval in bug 1305970

Comment 34

[Eric Rescorla (:ekr)]

Comment on attachment 8794052 [details]
Bug 1304919 - Update WebRTC to latest NSS,

This is one of three supporting patched for the 3.28 uplift to Beta. See approval in bug 1305970

Comment 35

[Eric Rescorla (:ekr)]

Specifically see:
https://bugzilla.mozilla.org/show_bug.cgi?id=1305970#c47

Comment 36

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8794050 [details]
Bug 1304919 - PSM changes to support TLS 1.3 key exchange,

OK to uplift to beta 51.

Comment 37

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8794052 [details]
Bug 1304919 - Update WebRTC to latest NSS,

OK for beta 51.

Comment 38

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Pushed to mozilla-beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/b632e57ae1940c9510a46d509cb044be4a954ba9
https://hg.mozilla.org/releases/mozilla-beta/rev/4178026a9a76aaa80ff3b3d7276a38999b0d249a
https://hg.mozilla.org/releases/mozilla-beta/rev/e30ea49b4bf4dd58b9620f1666af7d4dd47b017a
https://hg.mozilla.org/releases/mozilla-beta/rev/3db4e6dd305a9589f11bdb08aed157c94ffb1fe1

Comment 39

[Liz Henry (:lizzard) (relman/hg->git project)]

Gerry, can you add this  to the release notes, Updated to NSS 3.28.1 - with a link to https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.28.1_release_notes  ?
I am having some trouble getting into Nucleus right now, so i'm asking you in case I don't get it fixed today. Thanks!

Comment 40

[Liz Henry (:lizzard) (relman/hg->git project)]

I got the login issue straightened out. Release note added.