1305353 - Remove MediaDecoderStateMachine::DiscardStreamData()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

DecodedStream should discard audio data that are played by MSG without the help from MDSM. This also allows us to remove audio-capture specific code from MDSM.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1305353. Part 1 - publish output time to DecodedStream using MediaEventProducer.

Review commit: https://reviewboard.mozilla.org/r/81952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81952/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1305353. Part 2 - remove DecodedStreamData::GetPosition() and its friends.

Review commit: https://reviewboard.mozilla.org/r/81954/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81954/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1305353. Part 3 - discard audio samples in DecodedStream::NotifyOutput().

Review commit: https://reviewboard.mozilla.org/r/81956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81956/

Comment 4

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8795968 [details]
Bug 1305353. Part 1 - publish output time to DecodedStream using MediaEventProducer.

https://reviewboard.mozilla.org/r/81952/#review80562

Comment 5

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8795969 [details]
Bug 1305353. Part 2 - remove DecodedStreamData::GetPosition() and its friends.

https://reviewboard.mozilla.org/r/81954/#review80560

::: dom/media/mediasink/DecodedStream.cpp:269
(Diff revision 1)
>  {
>    AssertOwnerThread();
>    MOZ_ASSERT(mStartTime.isNothing(), "playback already started.");
>  
>    mStartTime.emplace(aStartTime);
> +  mLastOutputTime = 0;

nit: this should be in the previous patch.

Comment 6

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8795970 [details]
Bug 1305353. Part 3 - discard audio samples in DecodedStream::NotifyOutput().

https://reviewboard.mozilla.org/r/81956/#review80564

::: dom/media/mediasink/DecodedStream.cpp:708
(Diff revision 1)
>  DecodedStream::NotifyOutput(int64_t aTime)
>  {
>    AssertOwnerThread();
>    mLastOutputTime = aTime;
> +
> +  // Remove audio samples that are played by MSG from the queue.

nit: s/are played/have been played/

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8795968 [details]
Bug 1305353. Part 1 - publish output time to DecodedStream using MediaEventProducer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/81952/diff/1-2/

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8795969 [details]
Bug 1305353. Part 2 - remove DecodedStreamData::GetPosition() and its friends.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/81954/diff/1-2/

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8795970 [details]
Bug 1305353. Part 3 - discard audio samples in DecodedStream::NotifyOutput().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/81956/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3ac424edcd3
Part 1 - publish output time to DecodedStream using MediaEventProducer. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/1929112d6a82
Part 2 - remove DecodedStreamData::GetPosition() and its friends. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/8305ce9fcda4
Part 3 - discard audio samples in DecodedStream::NotifyOutput(). r=pehrsons

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a3ac424edcd3
https://hg.mozilla.org/mozilla-central/rev/1929112d6a82
https://hg.mozilla.org/mozilla-central/rev/8305ce9fcda4