1306813 - Intermittent test_peerConnection_capturedVideo.html,media-element-source-seek-1.html,test_video_dimensions.html,test_streams_srcObject.html | application terminated with exit code -139 after Assertion failure: aFailureHandling == DontAssertDispatchSuccess

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=4317462&repo=autoland

https://queue.taskcluster.net/v1/task/Cku2PTJ_TimprA2BjGCXwQ/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 2
* autoland: 2
* fx-team: 1

Platform breakdown:
* linux64: 3
* linux32: 1
* android-4-3-armv7-api15: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306813&startday=2016-09-26&endday=2016-10-02&tree=all

Comment 2

[Paul Adenot (:padenot)]

JW, this is crashing in `DecodedStreamGraphListener::NotifyOutput`, care to have a look ?

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1306813 - Don't puslish events to mOnOutput after DecodedStream::Stop() is called.

Because the TaskQueue of MDSM will shut down soon and TaskQueue::Dispatch() will fail (via mOnOutput.Notify()).
We reset mStream in Forget() on the TaskQueue thread of MDSM so NotifyOutput() can check it
and ensure mOnOutput.Notify() always happen before DecodedStream::Stop().

Review commit: https://reviewboard.mozilla.org/r/83236/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83236/

Comment 4

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8797540 [details]
Bug 1306813 - Don't puslish events to mOnOutput after DecodedStream::Stop() is called.

https://reviewboard.mozilla.org/r/83236/#review81720

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/223c97813e23
Don't puslish events to mOnOutput after DecodedStream::Stop() is called. r=pehrsons

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/223c97813e23

Comment 8

[Intermittent Failures Robot]

32 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 12
* mozilla-inbound: 11
* fx-team: 4
* mozilla-central: 3
* try: 2

Platform breakdown:
* linux64: 16
* linux32: 9
* android-4-3-armv7-api15: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306813&startday=2016-10-03&endday=2016-10-09&tree=all