Closed Bug 1306813 Opened 8 years ago Closed 8 years ago

Intermittent test_peerConnection_capturedVideo.html,media-element-source-seek-1.html,test_video_dimensions.html,test_streams_srcObject.html | application terminated with exit code -139 after Assertion failure: aFailureHandling == DontAssertDispatchSuccess

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla52

Tracking Flags:

Tracking

Status

firefox50

---

unaffected

firefox51

---

unaffected

firefox52

---

fixed

People

(Reporter: intermittent-bug-filer, Assigned: jwwang)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1306813 - Don't puslish events to mOnOutput after DecodedStream::Stop() is called. 8 years ago JW Wang [:jwwang] [:jw_wang] 58 bytes, text/x-review-board-request	pehrsons : review+	Details

Treeherder Bug Filer

Reporter

Description

•

8 years ago

treeherder

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=4317462&repo=autoland

https://queue.taskcluster.net/v1/task/Cku2PTJ_TimprA2BjGCXwQ/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Updated

•

8 years ago

Summary: Intermittent dom/media/tests/mochitest/test_peerConnection_capturedVideo.html | application terminated with exit code -139 after Assertion failure: aFailureHandling == DontAssertDispatchSuccess || ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1))) → Intermittent test_peerConnection_capturedVideo.html,media-element-source-seek-1.html | application terminated with exit code -139 after Assertion failure: aFailureHandling == DontAssertDispatchSuccess

Phil Ringnalda (:philor)

Updated

•

8 years ago

Summary: Intermittent test_peerConnection_capturedVideo.html,media-element-source-seek-1.html | application terminated with exit code -139 after Assertion failure: aFailureHandling == DontAssertDispatchSuccess → Intermittent test_peerConnection_capturedVideo.html,media-element-source-seek-1.html,test_video_dimensions.html | application terminated with exit code -139 after Assertion failure: aFailureHandling == DontAssertDispatchSuccess

Comment hidden (Intermittent Failures Robot)

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 2
* autoland: 2
* fx-team: 1

Platform breakdown:
* linux64: 3
* linux32: 1
* android-4-3-armv7-api15: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306813&startday=2016-09-26&endday=2016-10-02&tree=all

Paul Adenot (:padenot)

Comment 2

•

8 years ago

JW, this is crashing in `DecodedStreamGraphListener::NotifyOutput`, care to have a look ?

Flags: needinfo?(jwwang)

Paul Adenot (:padenot)

Updated

•

8 years ago

Rank: 35

Priority: -- → P3

Phil Ringnalda (:philor)

Updated

•

8 years ago

Component: WebRTC → Audio/Video

Summary: Intermittent test_peerConnection_capturedVideo.html,media-element-source-seek-1.html,test_video_dimensions.html | application terminated with exit code -139 after Assertion failure: aFailureHandling == DontAssertDispatchSuccess → Intermittent test_peerConnection_capturedVideo.html,media-element-source-seek-1.html,test_video_dimensions.html,test_streams_srcObject.html | application terminated with exit code -139 after Assertion failure: aFailureHandling == DontAssertDispatchSuccess

JW Wang [:jwwang] [:jw_wang]

Assignee

Updated

•

8 years ago

Assignee: nobody → jwwang

Blocks: 1305353

Component: Audio/Video → Audio/Video: Playback

Flags: needinfo?(jwwang)

Comment hidden (mozreview-request)

Because the TaskQueue of MDSM will shut down soon and TaskQueue::Dispatch() will fail (via mOnOutput.Notify()).
We reset mStream in Forget() on the TaskQueue thread of MDSM so NotifyOutput() can check it
and ensure mOnOutput.Notify() always happen before DecodedStream::Stop().

Review commit: https://reviewboard.mozilla.org/r/83236/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83236/

JW Wang [:jwwang] [:jw_wang]

Assignee

Updated

•

8 years ago

Attachment #8797540 - Flags: review?(pehrson)

Andreas Pehrson [:pehrsons]

Comment 4

•

8 years ago

mozreview-review

Comment on attachment 8797540 [details]
Bug 1306813 - Don't puslish events to mOnOutput after DecodedStream::Stop() is called.

https://reviewboard.mozilla.org/r/83236/#review81720

Attachment #8797540 - Flags: review?(pehrson) → review+

JW Wang [:jwwang] [:jw_wang]

Assignee

Comment 5

•

8 years ago

Thanks!

Pulsebot

Comment 6

•

8 years ago

Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/223c97813e23
Don't puslish events to mOnOutput after DecodedStream::Stop() is called. r=pehrsons

Carsten Book [:Tomcat]

Comment 7

•

8 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/223c97813e23

Status: NEW → RESOLVED

Closed: 8 years ago

status-firefox52: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla52

Ryan VanderMeulen [:RyanVM]

Updated

•

8 years ago

status-firefox50: --- → unaffected

status-firefox51: --- → unaffected

Comment hidden (Intermittent Failures Robot)

32 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 12
* mozilla-inbound: 11
* fx-team: 4
* mozilla-central: 3
* try: 2

Platform breakdown:
* linux64: 16
* linux32: 9
* android-4-3-armv7-api15: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1306813&startday=2016-10-03&endday=2016-10-09&tree=all

JW Wang [:jwwang] [:jw_wang]

Assignee

Updated

•

8 years ago

Blocks: 1315586

JW Wang [:jwwang] [:jw_wang]

Assignee

Updated

•

8 years ago

No longer blocks: 1315586

You need to log in before you can comment on or make changes to this bug.